Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCC75CA90AF for ; Wed, 13 May 2020 11:04:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A3E2C20769 for ; Wed, 13 May 2020 11:04:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="UT94uriD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730591AbgEMLE2 (ORCPT ); Wed, 13 May 2020 07:04:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728784AbgEMLE1 (ORCPT ); Wed, 13 May 2020 07:04:27 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB6A1C061A0C for ; Wed, 13 May 2020 04:04:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=VbfD2KvGIvBMNSYauqBakT43bABqCiMlwmjReq2hQqs=; b=UT94uriDHwk2xPz8bq/0oc3AFK 9rcu3hNB4osY+nalxGd6dpaBgUTicAsO4fOTygQ1AChFD2I2ZTxHSC0JEd5doRRIvjOtWTkRXB0Sr WZsmibNPNQ/NWKtY9sLt1EKpjxocX+f0bALqOJWZYeXfJnlT1fBO24WMZkNBPPQJWA8FfUAt/04yx XlHdBUIrD5/kNPpX7ISFonkpWdBdkSujk6is+YenKQg4vTcRHAwIX7IPiLUozwZsLJYgQ1Ajw/2iZ fkXb3bqkQhQnxJPhibQOPUMJpMR+Sgldj8RER/trySslzY2IDy8DzquhoLynCH+COJRnpwu0jhSud ehVMjcug==; Received: from [2001:4bb8:180:9d3f:c70:4a89:bc61:2] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYpBb-0006iO-CS; Wed, 13 May 2020 11:04:27 +0000 From: Christoph Hellwig To: axboe@kernel.dk Cc: linux-block@vger.kernel.org Subject: [PATCH 2/4] block: remove a pointless queue enter pair in blk_mq_alloc_request Date: Wed, 13 May 2020 13:04:17 +0200 Message-Id: <20200513110419.2362556-3-hch@lst.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200513110419.2362556-1-hch@lst.de> References: <20200513110419.2362556-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org No need for two queue references. Signed-off-by: Christoph Hellwig --- block/blk-mq.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index 9865a36e6a6e3..a3491c1397501 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -404,10 +404,7 @@ struct request *blk_mq_alloc_request(struct request_queue *q, unsigned int op, if (ret) return ERR_PTR(ret); - blk_queue_enter_live(q); rq = blk_mq_get_request(q, NULL, &alloc_data); - blk_queue_exit(q); - if (!rq) { blk_queue_exit(q); return ERR_PTR(-EWOULDBLOCK); -- 2.26.2