Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C67AC433E0 for ; Thu, 14 May 2020 00:55:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5807F2054F for ; Thu, 14 May 2020 00:55:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="N9neC9Qr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726050AbgENAzb (ORCPT ); Wed, 13 May 2020 20:55:31 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:59276 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725942AbgENAzb (ORCPT ); Wed, 13 May 2020 20:55:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=d+prNKplLXd2K9h6jzjwwwsYEMWulaw2jkRS28BAZlg=; b=N9neC9QrZURYUQnJBGGMdzVmMU wq3wW4mXPiTBYbdmLaZi1X0jizCYfXL+gzqcddxmvdv4dfGfoDkvcQD2hPaUmyOKmmNISb1eNTWDF K4VsGmu4NGxBsyvc/nEJP+uhm+TuaEcm93jKglfb/eG4CgcQfWk4sxIJvn4QahtBGVJ4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jZ29p-002EH6-BH; Thu, 14 May 2020 02:55:29 +0200 Date: Thu, 14 May 2020 02:55:29 +0200 From: Andrew Lunn To: Marek Vasut Cc: netdev@vger.kernel.org, "David S . Miller" , Lukas Wunner , Petr Stetiar , YueHaibing Subject: Re: [PATCH V5 08/19] net: ks8851: Use 16-bit writes to program MAC address Message-ID: <20200514005529.GE527401@lunn.ch> References: <20200514000747.159320-1-marex@denx.de> <20200514000747.159320-9-marex@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200514000747.159320-9-marex@denx.de> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, May 14, 2020 at 02:07:36AM +0200, Marek Vasut wrote: > On the SPI variant of KS8851, the MAC address can be programmed with > either 8/16/32-bit writes. To make it easier to support the 16-bit > parallel option of KS8851 too, switch both the MAC address programming > and readout to 16-bit operations. > > Remove ks8851_wrreg8() as it is not used anywhere anymore. > > There should be no functional change. > > Signed-off-by: Marek Vasut > Cc: David S. Miller > Cc: Lukas Wunner > Cc: Petr Stetiar > Cc: YueHaibing Reviewed-by: Andrew Lunn Andrew