Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 968CBC433DF for ; Fri, 15 May 2020 14:04:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 792FE20671 for ; Fri, 15 May 2020 14:04:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726189AbgEOOEa (ORCPT ); Fri, 15 May 2020 10:04:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726140AbgEOOEa (ORCPT ); Fri, 15 May 2020 10:04:30 -0400 Received: from orbyte.nwl.cc (orbyte.nwl.cc [IPv6:2001:41d0:e:133a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2B52C061A0C for ; Fri, 15 May 2020 07:04:29 -0700 (PDT) Received: from localhost ([::1]:52354 helo=tatos) by orbyte.nwl.cc with esmtp (Exim 4.91) (envelope-from ) id 1jZaw7-0006qn-Ng; Fri, 15 May 2020 16:04:26 +0200 From: Phil Sutter To: Pablo Neira Ayuso Cc: netfilter-devel@vger.kernel.org Subject: [iptables PATCH v2 0/2] Critical: Unbreak nfnl_osf tool Date: Fri, 15 May 2020 16:03:28 +0200 Message-Id: <20200515140330.13669-1-phil@nwl.cc> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org No changes in patch 1, it is still the right fix for the problem and restores original behaviour. Patch 2 changed according to feedback: - Elaborate on why there are duplicates in pf.os in the first place. - Ignore ENOENT when deleting. Since the code ignores EEXIST when creating, reporting this was asymmetrical behaviour. - Fix for ugly error message when user didn't specify '-f' option. Phil Sutter (2): nfnl_osf: Fix broken conversion to nfnl_query() nfnl_osf: Improve error handling utils/nfnl_osf.c | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) -- 2.26.2