Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9485C433E2 for ; Mon, 18 May 2020 17:07:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B06DC207E8 for ; Mon, 18 May 2020 17:07:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZM1d8VM/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B06DC207E8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iJkyNNeBnPLhSsQBE6OhSlhDbaeGOcKWq7qFxdvmQvA=; b=ZM1d8VM/EXJse5 3so1ki0LpW+pqjRyTRBIzFFy3Igt7tDTFt8BJFI2d3KjDJqKi+fMklvg+HwlKU7iyZ0hc4B6ZjkQ/ ieVoUgye+aFXqIT6Wx2/jtl9pwX7gcJ/FkwHPa9/AJZ+qw7if4fYMGn++AiYPJE+TccWi8T4QzpEz KoKx+gQvFyTQhAFkiXzqvfCaqn7BKT2ZnL2KMKpVGlO0la3qXYZa1fDQZ4ZMPSjEZXcPTMj5yVan2 1oMgFEW6DQKy5aUUbcdp+XLLlS/MR1VdpKGwrJajQTwBhWK9KO4L5LRfQadSttb5brOBhCk17xiH6 balKHwvVKa1TGuKUQPSg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jajED-0004YE-So; Mon, 18 May 2020 17:07:01 +0000 Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jajEC-0004Xv-9T; Mon, 18 May 2020 17:07:00 +0000 Date: Mon, 18 May 2020 10:07:00 -0700 From: Christoph Hellwig To: David Milburn Subject: Re: [PATCH 1/2] nvmet: check command slot before pulling and freeing aen Message-ID: <20200518170700.GA7418@infradead.org> References: <1589821386-43424-1-git-send-email-dmilburn@redhat.com> <1589821386-43424-2-git-send-email-dmilburn@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1589821386-43424-2-git-send-email-dmilburn@redhat.com> X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: chaitanya.kulkarni@wdc.com, hch@infradead.org, dwagner@suse.de, linux-nvme@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Mon, May 18, 2020 at 12:03:05PM -0500, David Milburn wrote: > static void nvmet_async_events_free(struct nvmet_ctrl *ctrl) > { > + struct nvmet_async_event *aen; > struct nvmet_req *req; > > mutex_lock(&ctrl->lock); > - while (ctrl->nr_async_event_cmds) { > + while (ctrl->nr_async_event_cmds && !list_empty(&ctrl->async_events)) { > + aen = list_first_entry(&ctrl->async_events, > + struct nvmet_async_event, entry); > + list_del(&aen->entry); > + kfree(aen); > + > req = ctrl->async_event_cmds[--ctrl->nr_async_event_cmds]; > mutex_unlock(&ctrl->lock); > nvmet_req_complete(req, NVME_SC_INTERNAL | NVME_SC_DNR); I don't think this change is correct. This loop just needs to complete all the requests that the host sent. The new loop added in the new patch should free any aens still queued on ->async_events, but be totally separate from the loop over the requests. _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme