From: Guenter Roeck Date: Tue, 19 May 2020 16:54:22 +0000 Subject: Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice Message-Id: <20200519165422.GA5838@roeck-us.net> List-Id: References: <20200507150004.1423069-8-ira.weiny@intel.com> <20200518184843.3029640-1-ira.weiny@intel.com> In-Reply-To: <20200518184843.3029640-1-ira.weiny@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ira.weiny@intel.com Cc: Peter Zijlstra , Dave Hansen , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, "James E.J. Bottomley" , Max Filippov , Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, Dan Williams , Helge Deller , x86@kernel.org, linux-csky@vger.kernel.org, Christoph Hellwig , Ingo Molnar , linux-snps-arc@lists.infradead.org, linux-xtensa@linux-xtensa.org, Borislav Petkov , Al Viro , Andy Lutomirski , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Chris Zankel , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Koenig , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" On Mon, May 18, 2020 at 11:48:43AM -0700, ira.weiny@intel.com wrote: > From: Ira Weiny > > The kunmap_atomic clean up failed to remove one set of pagefault/preempt > enables when vaddr is not in the fixmap. > > Fixes: bee2128a09e6 ("arch/kunmap_atomic: consolidate duplicate code") > Signed-off-by: Ira Weiny microblazeel works with this patch, as do the nosmp sparc32 boot tests, but sparc32 boot tests with SMP enabled still fail with lots of messages such as: BUG: Bad page state in process swapper/0 pfn:006a1 page:f0933420 refcount:0 mapcount:1 mapping:(ptrval) index:0x1 flags: 0x0() raw: 00000000 00000100 00000122 00000000 00000001 00000000 00000000 00000000 page dumped because: nonzero mapcount Modules linked in: CPU: 0 PID: 1 Comm: swapper/0 Tainted: G B 5.7.0-rc6-next-20200518-00002-gb178d2d56f29 #1 [f00e7ab8 : bad_page+0xa8/0x108 ] [f00e8b54 : free_pcppages_bulk+0x154/0x52c ] [f00ea024 : free_unref_page+0x54/0x6c ] [f00ed864 : free_reserved_area+0x58/0xec ] [f0527104 : kernel_init+0x14/0x110 ] [f000b77c : ret_from_kernel_thread+0xc/0x38 ] [00000000 : 0x0 ] Code path leading to that message is different but always the same from free_unref_page(). Still testing ppc images. Guenter