From: Laurent Pinchart Subject: Re: [PATCH 2/2] media: staging: rkisp1: stats: don't set stats flags in rkisp1_stats_send_measurement Date: Wed, 20 May 2020 03:16:01 +0300 Message-ID: <20200520001601.GN3820@pendragon.ideasonboard.com> References: <20200509152904.26348-1-dafna.hirschfeld@collabora.com> <20200509152904.26348-2-dafna.hirschfeld@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20200509152904.26348-2-dafna.hirschfeld@collabora.com> Sender: linux-media-owner@vger.kernel.org To: Dafna Hirschfeld Cc: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, helen.koike@collabora.com, ezequiel@collabora.com, dafna3@gmail.com, kernel@collabora.com, hverkuil@xs4all.nl, sakari.ailus@linux.intel.com, mchehab@kernel.org List-Id: linux-rockchip.vger.kernel.org Hi Dafna, Thank you for the patch. On Sat, May 09, 2020 at 05:29:04PM +0200, Dafna Hirschfeld wrote: > The flags that indicate which statistics are read are already > set in the functions that read them so there is no need to > set them in the function rkisp1_stats_send_measurement. > > Signed-off-by: Dafna Hirschfeld Reviewed-by: Laurent Pinchart > --- > drivers/staging/media/rkisp1/rkisp1-stats.c | 13 +++---------- > 1 file changed, 3 insertions(+), 10 deletions(-) > > diff --git a/drivers/staging/media/rkisp1/rkisp1-stats.c b/drivers/staging/media/rkisp1/rkisp1-stats.c > index 8351bda0be03..0616793ae395 100644 > --- a/drivers/staging/media/rkisp1/rkisp1-stats.c > +++ b/drivers/staging/media/rkisp1/rkisp1-stats.c > @@ -356,26 +356,19 @@ rkisp1_stats_send_measurement(struct rkisp1_stats *stats, > cur_stat_buf = > (struct rkisp1_stat_buffer *)(cur_buf->vaddr[0]); > > - if (meas_work->isp_ris & RKISP1_CIF_ISP_AWB_DONE) { > + if (meas_work->isp_ris & RKISP1_CIF_ISP_AWB_DONE) > rkisp1_stats_get_awb_meas(stats, cur_stat_buf); > - cur_stat_buf->meas_type |= RKISP1_CIF_ISP_STAT_AWB; > - } > > - if (meas_work->isp_ris & RKISP1_CIF_ISP_AFM_FIN) { > + if (meas_work->isp_ris & RKISP1_CIF_ISP_AFM_FIN) > rkisp1_stats_get_afc_meas(stats, cur_stat_buf); > - cur_stat_buf->meas_type |= RKISP1_CIF_ISP_STAT_AFM_FIN; > - } > > if (meas_work->isp_ris & RKISP1_CIF_ISP_EXP_END) { > rkisp1_stats_get_aec_meas(stats, cur_stat_buf); > rkisp1_stats_get_bls_meas(stats, cur_stat_buf); > - cur_stat_buf->meas_type |= RKISP1_CIF_ISP_STAT_AUTOEXP; > } > > - if (meas_work->isp_ris & RKISP1_CIF_ISP_HIST_MEASURE_RDY) { > + if (meas_work->isp_ris & RKISP1_CIF_ISP_HIST_MEASURE_RDY) > rkisp1_stats_get_hst_meas(stats, cur_stat_buf); > - cur_stat_buf->meas_type |= RKISP1_CIF_ISP_STAT_HIST; > - } > > vb2_set_plane_payload(&cur_buf->vb.vb2_buf, 0, > sizeof(struct rkisp1_stat_buffer)); -- Regards, Laurent Pinchart