Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDDABC433E0 for ; Thu, 21 May 2020 08:45:56 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 947FC207D3 for ; Thu, 21 May 2020 08:45:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 947FC207D3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jbgpd-0008KA-8j; Thu, 21 May 2020 08:45:37 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jbgpb-0008Iy-LU for xen-devel@lists.xenproject.org; Thu, 21 May 2020 08:45:35 +0000 X-Inumbo-ID: 6efb2dec-9b3f-11ea-aae5-12813bfff9fa Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6efb2dec-9b3f-11ea-aae5-12813bfff9fa; Thu, 21 May 2020 08:45:34 +0000 (UTC) Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 5oCZn25bClIxw0GsmZhUudrBK0bc81jdjDBeG8szzRIMS6ZMavw5YrZokg9KZwKLk1OK7pqcoY pdKSf2ARU/DdrmEwwT5TyCS8M73sFyWIxgOeK3PEkduB9gWtpCQCXKSwLbvCQRL+d2gPrY2epk dAp+2xrO2dqg0+77oW9rWXq5xczobgRgRd1OugBEbyKmQrgDR7bPQpdi+X92u209nTsbrbcuaQ OsCjcnOHwrZIKh5uKUZvRuDMK9kEkDn+yLH7lZVjLOflz1RguNiQsOhv3tk8LzISkk0+OGvP1k 6Ig= X-SBRS: 2.7 X-MesageID: 18093687 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.73,417,1583211600"; d="scan'208";a="18093687" Date: Thu, 21 May 2020 10:45:23 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Subject: Re: [PATCH v3 2/2] x86/idle: prevent entering C6 with in service interrupts on Intel Message-ID: <20200521084523.GP54375@Air-de-Roger> References: <20200515135802.63853-1-roger.pau@citrix.com> <20200515135802.63853-3-roger.pau@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: AMSPEX02CAS02.citrite.net (10.69.22.113) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Ian Jackson , George Dunlap , Jan Beulich , xen-devel@lists.xenproject.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Wed, May 20, 2020 at 10:30:11PM +0100, Andrew Cooper wrote: > On 15/05/2020 14:58, Roger Pau Monne wrote: > > Apply a workaround for Intel errata BDX99, CLX30, SKX100, CFW125, > > BDF104, BDH85, BDM135, KWB131: "A Pending Fixed Interrupt May Be > > Dispatched Before an Interrupt of The Same Priority Completes". > > HSM175 et al, so presumably a HSD, and HSE as well. > > On the broadwell side at least, BDD BDW in addition But those are a different errata AFAICT ('An APIC Timer Interrupt During Core C6 Entry May be Lost') and the workaround should also be different I think. We should mark the lapic timer as not reliable on C6 or higher states in lapic_timer_reliable_states, so that it's disabled before entering sleep? Thanks, Roger.