From: Michal Hocko Subject: Re: mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page Date: Thu, 21 May 2020 12:58:01 +0200 Message-ID: <20200521105801.GL6462@dhcp22.suse.cz> References: <20200501135806.4eebf0b92f84ab60bba3e1e7@linux-foundation.org> <20200519075213.GF32497@dhcp22.suse.cz> <20200519084535.GG32497@dhcp22.suse.cz> <20200520190906.GA558281@chrisdown.name> <20200521095515.GK6462@dhcp22.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=XNawhknjOIKR4nsDknlNKTgt07zaj8UbYNFvZIbzSoA=; b=GwYnvX+JUnM75K0WKVkf9jhLhF JaKHWgi5uZNFgx5HwbXMR6hH73B0iH5fYfDB+qtvj8DuxVehjwyGHzDBK61JYs1Zi36iGDxtMk8jj Y+L/g6VAIUk+nWYuoQ0oJAEGEf0HsoW63pAAtisi4t+8zYa3D3/efkMNxgKXe9QcYkv8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=XNawhknjOIKR4nsDknlNKTgt07zaj8UbYNFvZIbzSoA=; b=iS3WdsQFZjt5TQ57zef7TlWerJ FeFMXBPdJbbv3JB18CHnQhT+YrMyVAFmlohrqeA3oG13mOhdX/b52tfsGuxKSWHBsv5eadG4oOAXD W1SRDivEu9jE5nGZ31JBLHJsImhY1bi8Wn14UqyBQl6W94FXGNj8bSg3jvDN7J4ek8HQ=; Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Naresh Kamboju Cc: lkft-triage@lists.linaro.org, linux-mm , Yafang Shao , Andreas Dilger , Cgroups , Andrea Arcangeli , Anders Roxell , Hugh Dickins , Matthew Wilcox , Linux-Next Mailing List , linux-ext4 , Arnd Bergmann , linux-block , Jaegeuk Kim , Theodore Ts'o , Chris Down , open list , "Linux F2FS DEV, Mailing List" , Johannes Weiner , Andrew Morton , Roman Gushchin On Thu 21-05-20 16:11:11, Naresh Kamboju wrote: > On Thu, 21 May 2020 at 15:25, Michal Hocko wrote: > > > > On Wed 20-05-20 20:09:06, Chris Down wrote: > > > Hi Naresh, > > > > > > Naresh Kamboju writes: > > > > As a part of investigation on this issue LKFT teammate Anders Roxell > > > > git bisected the problem and found bad commit(s) which caused this problem. > > > > > > > > The following two patches have been reverted on next-20200519 and retested the > > > > reproducible steps and confirmed the test case mkfs -t ext4 got PASS. > > > > ( invoked oom-killer is gone now) > > > > > > > > Revert "mm, memcg: avoid stale protection values when cgroup is above > > > > protection" > > > > This reverts commit 23a53e1c02006120f89383270d46cbd040a70bc6. > > > > > > > > Revert "mm, memcg: decouple e{low,min} state mutations from protection > > > > checks" > > > > This reverts commit 7b88906ab7399b58bb088c28befe50bcce076d82. > > > > > > Thanks Anders and Naresh for tracking this down and reverting. > > > > > > I'll take a look tomorrow. I don't see anything immediately obviously wrong > > > in either of those commits from a (very) cursory glance, but they should > > > only be taking effect if protections are set. > > > > Agreed. If memory.{low,min} is not used then the patch should be > > effectively a nop. Btw. do you see the problem when booting with > > cgroup_disable=memory kernel command line parameter? > > With extra kernel command line parameters, cgroup_disable=memory > I have noticed a differ problem now. > > + mkfs -t ext4 /dev/disk/by-id/ata-TOSHIBA_MG04ACA100N_Y8NRK0BPF6XF > mke2fs 1.43.8 (1-Jan-2018) > Creating filesystem with 244190646 4k blocks and 61054976 inodes > Filesystem UUID: 3bb1a285-2cb4-44b4-b6e8-62548f3ac620 > Superblock backups stored on blocks: > 32768, 98304, 163840, 229376, 294912, 819200, 884736, 1605632, 2654208, > 4096000, 7962624, 11239424, 20480000, 23887872, 71663616, 78675968, > 102400000, 214990848 > Allocating group tables: 0/7453 done > Writing inode tables: 0/7453 done > Creating journal (262144 blocks): [ 35.502102] BUG: kernel NULL > pointer dereference, address: 000000c8 > [ 35.508372] #PF: supervisor read access in kernel mode > [ 35.513506] #PF: error_code(0x0000) - not-present page > [ 35.518638] *pde = 00000000 > [ 35.521514] Oops: 0000 [#1] SMP > [ 35.524652] CPU: 0 PID: 145 Comm: kswapd0 Not tainted > 5.7.0-rc6-next-20200519+ #1 > [ 35.532121] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS > 2.2 05/23/2018 > [ 35.539507] EIP: mem_cgroup_get_nr_swap_pages+0x28/0x60 Could you get faddr2line for this offset? -- Michal Hocko SUSE Labs