From: Thomas Petazzoni Date: Thu, 21 May 2020 15:36:19 +0200 Subject: [Buildroot] [PATCH 1/1] package/linuxptp: remove hardcoded interface from config to args In-Reply-To: <20200520051647.18530-1-heiko.thiery@gmail.com> References: <20200520051647.18530-1-heiko.thiery@gmail.com> Message-ID: <20200521153619.5466d4e6@windsurf.home> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello Heiko, On Wed, 20 May 2020 07:16:48 +0200 Heiko Thiery wrote: > Interface configuration is hard coded in the config file. This will > throw an error when this interace (eth0) is not present. > > This patch removes the interface to be used from the config and appends it > to the PTP4L_ARGS. With this the custom arguments can be set via > /etc/defaults/ptp4l. Well, you can also just as well provide your custom linuxptp.cfg in a rootfs overlay, no? Also, your change to linuxptp.cfg kind of breaks what is explained in linuxptp.cfg: # By default synchronize time in slave-only mode using UDP and hardware time # stamps on eth0. If the difference to master is >1.0 second correct by # stepping the clock instead of adjusting the frequency. Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com