Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73988C433E0 for ; Thu, 21 May 2020 20:45:02 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 084DB20748 for ; Thu, 21 May 2020 20:45:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 084DB20748 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=improbability.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A38A86E957; Thu, 21 May 2020 20:45:01 +0000 (UTC) X-Greylist: delayed 915 seconds by postgrey-1.36 at gabe; Thu, 21 May 2020 20:45:01 UTC Received: from relay1.stackmail.com (relay1.stackmail.com [185.151.28.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 346006E957 for ; Thu, 21 May 2020 20:45:01 +0000 (UTC) Received: from smtp1.mail.stackcp.net ([10.4.72.75] helo=smtp1.n4.stackcp.net) by relay1.stackmail.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) (envelope-from ) id 1jbrp2-0005FO-GM for amd-gfx@lists.freedesktop.org; Thu, 21 May 2020 21:29:44 +0100 Received: from slartibartfast.improbability.net ([87.127.90.134]) by smtp1.n4.stackcp.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) (envelope-from ) id 1jbrp2-0004hU-9W for amd-gfx@lists.freedesktop.org; Thu, 21 May 2020 21:29:44 +0100 Received: from trillian.improbability.net (trillian.improbability.net [87.127.90.131]) by slartibartfast.improbability.net (Postfix) with ESMTPSA id CF2012622A; Thu, 21 May 2020 21:29:43 +0100 (BST) From: Alan Swanson To: amd-gfx@lists.freedesktop.org Subject: [PATCH 2/2] drm/amdgpu: Advise if unable to resize BAR Date: Thu, 21 May 2020 21:29:31 +0100 Message-Id: <20200521202931.15726-2-reiver@improbability.net> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200521202931.15726-1-reiver@improbability.net> References: <20200521202931.15726-1-reiver@improbability.net> MIME-Version: 1.0 X-Authenticated-Sender: alan@improbability.net X-Scan-Signature: 87851ef79f0dbeade26879b66857a652 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alan Swanson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Even with the "Above 4G decoding" (or similar) BIOS option enabled, many BIOS do not assign the PCI root bus a 64-bit address space. If available, "MMIOH Base" and "MMIO High Size" (or similar) BIOS options should allow mapping to the desired address spaces. Signed-off-by: Alan Swanson --- Useful to know why bar resizing isn't happening. drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index 2f0e8da7b..39a7f7212 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c @@ -919,8 +919,10 @@ int amdgpu_device_resize_fb_bar(struct amdgpu_device *adev) } /* Trying to resize is pointless without a root hub window above 4GB */ - if (!res) + if (!res) { + DRM_INFO("Unable to resize BAR as PCI bus address space below 4GB."); return 0; + } /* Disable memory decoding while we change the BAR addresses and size */ pci_read_config_word(adev->pdev, PCI_COMMAND, &cmd); -- 2.26.2 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx