Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A24D7C433E0 for ; Sat, 23 May 2020 02:55:17 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2C70C206DD for ; Sat, 23 May 2020 02:55:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="jtAnBnD6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C70C206DD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amd.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AF2F16E177; Sat, 23 May 2020 02:55:16 +0000 (UTC) Received: from NAM04-SN1-obe.outbound.protection.outlook.com (mail-eopbgr700047.outbound.protection.outlook.com [40.107.70.47]) by gabe.freedesktop.org (Postfix) with ESMTPS id C13096E177 for ; Sat, 23 May 2020 02:55:14 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QpmXqP6bNQWUyZM0bNRbv8maAzYB+N9GflN+lA9y3V+W9t75YR2kcg2VpRpHBEFYUvNpg2ChyBCLbCyZGMw1fxGLzoyJvUE7CD5Nqy2KszaBdTmC4Rt37myJmc/Xtrc+CzspD6dPeGvAJ010OrSNLrBNBup9y8pPdj5UWFVsRBGlGnqsb37p3jE6MypG2JeTZIYtpYMH1b+s8p2ElNA1cFldnbX3Sqkn0z/1ze3ciRWfHlIEG1di3Ne0oym8PkDtFe875FeLeipcer8hN3/lw+iC4c3/PpwdUb3qm3ngb/18jN+bAE2qvkFYVZb7N3PuKAgE4cDLrFKKtKqGHows9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n5ZlQLlZr6g1U790Hkli4DpccR3A1hgRlMpi7HDYFS4=; b=asEjUN+KtIRklnza5dZDe2v1SCGMKmh7IYUPAsIEIWUJEKANohd2y+UiR2Rd7f9vTIyGeQ8pztKCS2ovePC/83BZ+1AW43SmRAjuO3c13RWEVMw5Kr73/me0DJaBGPrhpavFLD3d/Wy8oo0B75IwuJRyACGL/meqasJaOUD9LV9Wg1R4KtGmnqA8RPWZgVvswk1DUFsme3tx7Eow7j35jQhHaIwzWFLIgLxCLyX09+xXslnQorV6tvouQkL5WlAXc/mz+LBsvXUQ/XMfcZQ+glm0779xask0prAuIFzLAVUy2NHf1PmxNjB74x+o8cbXSx/3q0Ct220ElT0hoOT6ng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n5ZlQLlZr6g1U790Hkli4DpccR3A1hgRlMpi7HDYFS4=; b=jtAnBnD6vY6pmoJyRN05ei3Gd6HtmZIkyF6w2J+nCaEZjJS7HMY/3MYOp/q0kWxU6xsoGZ9W06Y6HfQuQDyOJ/yhtjwwc8vpykHAk2dkwojsdZo7EmynQRzM/Iw0bnEeSUjfwSv+MTEHFya6FKMsDSwF+ZNTTvid5QsF8YXGThU= Authentication-Results: lists.freedesktop.org; dkim=none (message not signed) header.d=none; lists.freedesktop.org; dmarc=none action=none header.from=amd.com; Received: from BN7PR12MB2836.namprd12.prod.outlook.com (2603:10b6:408:32::33) by BN7PR12MB2835.namprd12.prod.outlook.com (2603:10b6:408:30::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.27; Sat, 23 May 2020 02:55:12 +0000 Received: from BN7PR12MB2836.namprd12.prod.outlook.com ([fe80::14f2:9ef9:beed:ad1]) by BN7PR12MB2836.namprd12.prod.outlook.com ([fe80::14f2:9ef9:beed:ad1%7]) with mapi id 15.20.3021.024; Sat, 23 May 2020 02:55:12 +0000 From: Mukul Joshi To: amd-gfx@lists.freedesktop.org Subject: [PATCH v2] drm/amdkfd: Track SDMA utilization per process Date: Fri, 22 May 2020 22:54:57 -0400 Message-Id: <20200523025457.26563-1-mukul.joshi@amd.com> X-Mailer: git-send-email 2.17.1 X-ClientProxiedBy: YT1PR01CA0133.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:2f::12) To BN7PR12MB2836.namprd12.prod.outlook.com (2603:10b6:408:32::33) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from Ryzen-3700X.amd.com (165.204.55.251) by YT1PR01CA0133.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:2f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.24 via Frontend Transport; Sat, 23 May 2020 02:55:12 +0000 X-Mailer: git-send-email 2.17.1 X-Originating-IP: [165.204.55.251] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 74073755-a753-4b95-c3c8-08d7fec4b653 X-MS-TrafficTypeDiagnostic: BN7PR12MB2835: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:758; X-Forefront-PRVS: 0412A98A59 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nvQJ0PNwyiwwJId0z2ji0z0UwXTN/rGZIuaz7FE4Z78REXZo2esoHoUdiygsYVNugzoV1/3oKgADLQcXRFeGcPjnMKxn0ao9ywgwIFdhT8EDAFPi1FbmwBWzmNmAbX9YKEizVHxsq5RKFEJmYkhxVTmrKw188WmkoD5z9jdqaXSFdR+jHSOEcnztsNuPCPuuuJuCQD9TqwiVjhf3bX79H9e6C3Ik9qO1uJ3SpgiD6DpHbqZRudkMG6DDGy1oiP8KA9rqq2rDo3i9onZOQm2whRG40yUljePQJ6SkIT359Y0FG8b6gS5U28H7PFdPzbZJkwNKjBlUl7FO/JU5eF52tbMcsF33Rht1mA/NptQCMGGCtO4EF4rdfbBuKq0RchZzoBmr2j6Wxt7OyK/x2F+JKMwmA629SbD2HkMTxvsiSN+hOBbAlW5UpCASaPIanLVl X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN7PR12MB2836.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(39860400002)(346002)(376002)(396003)(136003)(6486002)(2906002)(956004)(16526019)(186003)(26005)(6916009)(36756003)(2616005)(6666004)(52116002)(44832011)(8936002)(7696005)(4326008)(30864003)(478600001)(8676002)(66946007)(5660300002)(66476007)(316002)(86362001)(66556008)(1076003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: HgTcGyJonHzkZRv1qWLDJD2o0S8z4BDf4bIdPc8p8rjEu+iTAmFvxmtEjGUrNhHRUI0A0BPjNdl3bpwTwLmPxo8z9WUCFmZSMb71/uGu5652vtlzEFfyPLYCbfTQhICzD/JWrnsUt9iNhg9IUamQXKy1dYofWekWzaAhKB3EPr6YppFREOMq3sMG5cqbqwnQmOL4Rihmf9z5ZFPFuhl/U0DPP/1JAinNf8HoswwNWi9n8YkXU6ujNLHBgpG7jCRPHgEd9bkeudS/30JzQrS4M9LCCSC0sNRZ3qfmqCOBJpeteKTGgGzsZmFCVn1qJvBcqbTbLLaSbZelxJ6rWx46fTI7FdrhbSKqTnIn5ArkwTq50ZSetfR7EiUA/i35DZZrJ9HpneYIPFK4w+FF2myPwYkh7fXBXSwkVzmQJxpnCkgJM8ghpddw+pD6/RmyH1CYVl/8fvTqrGHzonfQVm84kBLT6oprTlvGA6eidHZD+bpl2CdAeiTeYYDzzUcMdnsS X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 74073755-a753-4b95-c3c8-08d7fec4b653 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2020 02:55:12.4421 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8awYipyjGLMq3gLVf5iJh/SMWt7aWJSU2T55jqBxdJ5E/RJ/h46sGhYD62WywOOAl560rcDG3yJlMzLU43W3Cg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR12MB2835 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mukul Joshi , Felix.Kuehling@amd.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Track SDMA usage on a per process basis and report it through sysfs. The value in the sysfs file indicates the amount of time SDMA has been in-use by this process since the creation of the process. This value is in microsecond granularity. v2: - Remove unnecessary checks for pdd is kfd_procfs_show(). - Make counter part of the kfd_sdma_activity_handler_workarea structure. Signed-off-by: Mukul Joshi --- .../drm/amd/amdkfd/kfd_device_queue_manager.c | 57 ++++++++ .../drm/amd/amdkfd/kfd_device_queue_manager.h | 2 + drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 16 ++- drivers/gpu/drm/amd/amdkfd/kfd_process.c | 130 ++++++++++++++++-- 4 files changed, 191 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c index e9c4867abeff..49f72d0f7be7 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c @@ -153,6 +153,52 @@ void decrement_queue_count(struct device_queue_manager *dqm, dqm->active_cp_queue_count--; } +int read_sdma_queue_counter(struct queue *q, uint64_t *val) +{ + int ret; + uint64_t tmp = 0; + + if (!q || !val) + return -EINVAL; + /* + * SDMA activity counter is stored at queue's RPTR + 0x8 location. + */ + if (!access_ok((const void __user *)((uint64_t)q->properties.read_ptr + + sizeof(uint64_t)), sizeof(uint64_t))) { + pr_err("Can't access sdma queue activity counter\n"); + return -EFAULT; + } + + ret = get_user(tmp, (uint64_t *)((uint64_t)(q->properties.read_ptr) + + sizeof(uint64_t))); + if (!ret) { + *val = tmp; + } + + return ret; +} + +static int update_sdma_queue_past_activity_stats(struct kfd_process_device *pdd, + struct queue *q) +{ + int ret; + uint64_t val = 0; + + if (!pdd) + return -ENODEV; + + ret = read_sdma_queue_counter(q, &val); + if (ret) { + pr_err("Failed to read SDMA queue counter for queue: %d\n", + q->properties.queue_id); + return ret; + } + + WRITE_ONCE(pdd->sdma_past_activity_counter, pdd->sdma_past_activity_counter + val); + + return ret; +} + static int allocate_doorbell(struct qcm_process_device *qpd, struct queue *q) { struct kfd_dev *dev = qpd->dqm->dev; @@ -487,6 +533,12 @@ static int destroy_queue_nocpsch_locked(struct device_queue_manager *dqm, if (retval == -ETIME) qpd->reset_wavefronts = true; + /* Get the SDMA queue stats */ + if ((q->properties.type == KFD_QUEUE_TYPE_SDMA) || + (q->properties.type == KFD_QUEUE_TYPE_SDMA_XGMI)) { + update_sdma_queue_past_activity_stats(qpd_to_pdd(qpd), q); + } + mqd_mgr->free_mqd(mqd_mgr, q->mqd, q->mqd_mem_obj); list_del(&q->list); @@ -1468,6 +1520,11 @@ static int destroy_queue_cpsch(struct device_queue_manager *dqm, } } + /* Get the SDMA queue stats */ + if ((q->properties.type == KFD_QUEUE_TYPE_SDMA) || + (q->properties.type == KFD_QUEUE_TYPE_SDMA_XGMI)) { + update_sdma_queue_past_activity_stats(qpd_to_pdd(qpd), q); + } /* * Unconditionally decrement this counter, regardless of the queue's * type diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.h b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.h index 4afa015c69b1..894bcf877f9e 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.h +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.h @@ -251,4 +251,6 @@ static inline void dqm_unlock(struct device_queue_manager *dqm) mutex_unlock(&dqm->lock_hidden); } +int read_sdma_queue_counter(struct queue *q, uint64_t *val); + #endif /* KFD_DEVICE_QUEUE_MANAGER_H_ */ diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_priv.h b/drivers/gpu/drm/amd/amdkfd/kfd_priv.h index f70f789c3cb3..fae139b77c0a 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_priv.h +++ b/drivers/gpu/drm/amd/amdkfd/kfd_priv.h @@ -633,7 +633,14 @@ enum kfd_pdd_bound { PDD_BOUND_SUSPENDED, }; -#define MAX_VRAM_FILENAME_LEN 11 +#define MAX_SYSFS_FILENAME_LEN 11 + +/* + * SDMA counter runs at 100MHz frequency. + * We display SDMA activity in microsecond granularity in sysfs. + * As a result, the divisor is 100. + */ +#define SDMA_ACTIVITY_DIVISOR 100 /* Data that is per-process-per device. */ struct kfd_process_device { @@ -681,7 +688,12 @@ struct kfd_process_device { /* VRAM usage */ uint64_t vram_usage; struct attribute attr_vram; - char vram_filename[MAX_VRAM_FILENAME_LEN]; + char vram_filename[MAX_SYSFS_FILENAME_LEN]; + + /* SDMA activity tracking */ + uint64_t sdma_past_activity_counter; + struct attribute attr_sdma; + char sdma_filename[MAX_SYSFS_FILENAME_LEN]; }; #define qpd_to_pdd(x) container_of(x, struct kfd_process_device, qpd) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c b/drivers/gpu/drm/amd/amdkfd/kfd_process.c index d27221ddcdeb..e2ebed5c033f 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c @@ -25,6 +25,7 @@ #include #include #include +#include #include #include #include @@ -76,6 +77,66 @@ struct kfd_procfs_tree { static struct kfd_procfs_tree procfs; +/* + * Structure for SDMA activity tracking + */ +struct kfd_sdma_activity_handler_workarea { + struct work_struct sdma_activity_work; + struct kfd_process_device *pdd; + uint64_t sdma_current_activity_counter; +}; + +static void kfd_sdma_activity_worker(struct work_struct *work) +{ + struct kfd_sdma_activity_handler_workarea *workarea; + struct kfd_process_device *pdd; + uint64_t val; + struct mm_struct *mm; + struct queue *q; + struct qcm_process_device *qpd; + struct device_queue_manager *dqm; + int ret = 0; + + workarea = container_of(work, struct kfd_sdma_activity_handler_workarea, + sdma_activity_work); + if (!workarea) + return; + + pdd = workarea->pdd; + dqm = pdd->dev->dqm; + qpd = &pdd->qpd; + + if (!pdd || !dqm || !qpd) + return; + + mm = get_task_mm(pdd->process->lead_thread); + if (!mm) { + return; + } + + use_mm(mm); + + dqm_lock(dqm); + + list_for_each_entry(q, &qpd->queues_list, list) { + if ((q->properties.type == KFD_QUEUE_TYPE_SDMA) || + (q->properties.type == KFD_QUEUE_TYPE_SDMA_XGMI)) { + val = 0; + ret = read_sdma_queue_counter(q, &val); + if (ret) + pr_debug("Failed to read SDMA queue active " + "counter for queue id: %d", + q->properties.queue_id); + else + workarea->sdma_current_activity_counter += val; + } + } + + dqm_unlock(dqm); + unuse_mm(mm); + mmput(mm); +} + static ssize_t kfd_procfs_show(struct kobject *kobj, struct attribute *attr, char *buffer) { @@ -87,8 +148,25 @@ static ssize_t kfd_procfs_show(struct kobject *kobj, struct attribute *attr, } else if (strncmp(attr->name, "vram_", 5) == 0) { struct kfd_process_device *pdd = container_of(attr, struct kfd_process_device, attr_vram); - if (pdd) - return snprintf(buffer, PAGE_SIZE, "%llu\n", READ_ONCE(pdd->vram_usage)); + return snprintf(buffer, PAGE_SIZE, "%llu\n", READ_ONCE(pdd->vram_usage)); + } else if (strncmp(attr->name, "sdma_", 5) == 0) { + struct kfd_process_device *pdd = container_of(attr, struct kfd_process_device, + attr_sdma); + struct kfd_sdma_activity_handler_workarea sdma_activity_work_handler; + + INIT_WORK(&sdma_activity_work_handler.sdma_activity_work, + kfd_sdma_activity_worker); + + sdma_activity_work_handler.pdd = pdd; + + schedule_work(&sdma_activity_work_handler.sdma_activity_work); + + flush_work(&sdma_activity_work_handler.sdma_activity_work); + + return snprintf(buffer, PAGE_SIZE, "%llu\n", + (READ_ONCE(pdd->sdma_past_activity_counter) + + sdma_activity_work_handler.sdma_current_activity_counter)/ + SDMA_ACTIVITY_DIVISOR); } else { pr_err("Invalid attribute"); return -EINVAL; @@ -210,7 +288,24 @@ int kfd_procfs_add_queue(struct queue *q) return 0; } -int kfd_procfs_add_vram_usage(struct kfd_process *p) +static int kfd_sysfs_create_file(struct kfd_process *p, struct attribute *attr, + char *name) +{ + int ret = 0; + + if (!p || !attr || !name) + return -EINVAL; + + attr->name = name; + attr->mode = KFD_SYSFS_FILE_MODE; + sysfs_attr_init(attr); + + ret = sysfs_create_file(p->kobj, attr); + + return ret; +} + +int kfd_procfs_add_sysfs_files(struct kfd_process *p) { int ret = 0; struct kfd_process_device *pdd; @@ -221,17 +316,25 @@ int kfd_procfs_add_vram_usage(struct kfd_process *p) if (!p->kobj) return -EFAULT; - /* Create proc//vram_ file for each GPU */ + /* + * Create sysfs files for each GPU: + * - proc//vram_ + * - proc//sdma_ + */ list_for_each_entry(pdd, &p->per_device_data, per_device_list) { - snprintf(pdd->vram_filename, MAX_VRAM_FILENAME_LEN, "vram_%u", + snprintf(pdd->vram_filename, MAX_SYSFS_FILENAME_LEN, "vram_%u", pdd->dev->id); - pdd->attr_vram.name = pdd->vram_filename; - pdd->attr_vram.mode = KFD_SYSFS_FILE_MODE; - sysfs_attr_init(&pdd->attr_vram); - ret = sysfs_create_file(p->kobj, &pdd->attr_vram); + ret = kfd_sysfs_create_file(p, &pdd->attr_vram, pdd->vram_filename); if (ret) pr_warn("Creating vram usage for gpu id %d failed", (int)pdd->dev->id); + + snprintf(pdd->sdma_filename, MAX_SYSFS_FILENAME_LEN, "sdma_%u", + pdd->dev->id); + ret = kfd_sysfs_create_file(p, &pdd->attr_sdma, pdd->sdma_filename); + if (ret) + pr_warn("Creating sdma usage for gpu id %d failed", + (int)pdd->dev->id); } return ret; @@ -444,9 +547,9 @@ struct kfd_process *kfd_create_process(struct file *filep) if (!process->kobj_queues) pr_warn("Creating KFD proc/queues folder failed"); - ret = kfd_procfs_add_vram_usage(process); + ret = kfd_procfs_add_sysfs_files(process); if (ret) - pr_warn("Creating vram usage file for pid %d failed", + pr_warn("Creating sysfs usage file for pid %d failed", (int)process->lead_thread->pid); } out: @@ -597,8 +700,10 @@ static void kfd_process_wq_release(struct work_struct *work) kobject_put(p->kobj_queues); p->kobj_queues = NULL; - list_for_each_entry(pdd, &p->per_device_data, per_device_list) + list_for_each_entry(pdd, &p->per_device_data, per_device_list) { sysfs_remove_file(p->kobj, &pdd->attr_vram); + sysfs_remove_file(p->kobj, &pdd->attr_sdma); + } kobject_del(p->kobj); kobject_put(p->kobj); @@ -906,6 +1011,7 @@ struct kfd_process_device *kfd_create_process_device_data(struct kfd_dev *dev, pdd->already_dequeued = false; pdd->runtime_inuse = false; pdd->vram_usage = 0; + pdd->sdma_past_activity_counter = 0; list_add(&pdd->per_device_list, &p->per_device_data); /* Init idr used for memory handle translation */ -- 2.17.1 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx