Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67A00C433DF for ; Tue, 26 May 2020 15:43:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3FE1820663 for ; Tue, 26 May 2020 15:43:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="Y/aJG4Y8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729311AbgEZPne (ORCPT ); Tue, 26 May 2020 11:43:34 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:49854 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727898AbgEZPne (ORCPT ); Tue, 26 May 2020 11:43:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=T0ePco9bS8ijwIRr1MySMZuVMfVVvC60IggVOTHnYQg=; b=Y/aJG4Y8W4oDDqouWWLmgP0dQl DhLKSCIUOP0yopIisym6WYPmzyHL5Wf9PJpd7RNFT4+1S5AoTP/XuHnU0lJX/SzDleQMkDZLy7rp7 mRJj2cqAgw+ZNbmzSV/rThPer1tIsvGUNanBpDXstM1zA2A7xPiHN5oJN/2PTlIfaqzw=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jdbji-003IU1-9L; Tue, 26 May 2020 17:43:26 +0200 Date: Tue, 26 May 2020 17:43:26 +0200 From: Andrew Lunn To: Russell King Cc: Florian Fainelli , Heiner Kallweit , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, Jeremy Linton Subject: Re: [PATCH net-next] net: mdiobus: add clause 45 mdiobus accessors Message-ID: <20200526154326.GB782807@lunn.ch> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, May 26, 2020 at 04:29:36PM +0100, Russell King wrote: > There is a recurring pattern throughout some of the PHY code converting > a devad and regnum to our packed clause 45 representation. Rather than > having this scattered around the code, let's put a common translation > function in mdio.h, and provide some register accessors. > > Convert the phylib core, phylink, bcm87xx and cortina to use these. > > Signed-off-by: Russell King Reviewed-by: Andrew Lunn Andrew