Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by mx.groups.io with SMTP id smtpd.web10.479.1590526269179612011 for ; Tue, 26 May 2020 13:51:09 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=eSgDGPvh; spf=pass (domain: gmail.com, ip: 209.85.214.194, mailfrom: raj.khem@gmail.com) Received: by mail-pl1-f194.google.com with SMTP id d3so9194859pln.1 for ; Tue, 26 May 2020 13:51:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Ver65tQILyhlpzdtv88aIi0GmV/yiMeOPBeChmrMvTE=; b=eSgDGPvhgxcFJhiB5ei/2UT5pxD7qmYLf+yRsubV2iVrHr0Bq01rUI+QrdVNrXtNNz ZwwoVW4PPej3isZGIlE+q7XccmP+wE5QwtQkVZ8AZU/bGXRUCNcBnQYD/XVqpfjZZdTc aQAD5aNNRkmZyBCd9COIIpBGOG/GyYTHTjajqQZwFLwRsrFxGv1GjC2bqXtRi90DVQGt HJn0GuELqZFi6i4bBkVii6MfGa73evl967lSP8T+sjyeCCmC59r0XdbYkVeR0YVQq8Dz YlAeASEzhWlU/t19lm6yOw2JEehR8IEj2cPNvmKwJwKbHNjAfHia43QHVT4p7wY6pHKW kdsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Ver65tQILyhlpzdtv88aIi0GmV/yiMeOPBeChmrMvTE=; b=gdcP6Uo7LA0IIVwxuhKcWZzZDcpXnmPAK3bpgi1elfsexD2wSi8Dt9MgBycUL2jp/y sjPAYjh8EhiEB53by6q8q1Ic2P05fYzXsnAQxqwsiiTVUpdmYvVGYuqKBFjpjl/pN0uk Gtm0ilMHhVtQV8myFw4V9Jm18teQFIRxoDYjc1fmf49V+pzewOemZwpSrLgGVTOF4HJB LsCMhHFMdlHhtS2AjLMS9ii5gCf1hB1DV+OKKT4fwA/KKIN//5GE8weO7T5OnZPbW+AC wQKcRjq6gPn+UNO/VBJB5n96XVd/H/qMj3p42nOys6s2a5exhOYTRsC96cqr2IgKhx0M Xv/Q== X-Gm-Message-State: AOAM532wXjKuj5KmyQmKJZxlIMaFJp6lMv/PEtWWlpvRYQ6Bpq2fnH/q jJrdPpqurOvfwTFjyvbsGSAm4CPoNek= X-Google-Smtp-Source: ABdhPJzZW9hBw22iOyhfMAJs3T1WzGixDz/o1/WjtOiyLcIGUKpZVNln2pRhaTO7k3oUMDxpr+1tzw== X-Received: by 2002:a17:90b:4c88:: with SMTP id my8mr1112462pjb.176.1590526267897; Tue, 26 May 2020 13:51:07 -0700 (PDT) Return-Path: Received: from apollo.hsd1.ca.comcast.net (c-73-63-224-124.hsd1.ca.comcast.net. [73.63.224.124]) by smtp.gmail.com with ESMTPSA id a2sm437216pgh.81.2020.05.26.13.51.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 May 2020 13:51:07 -0700 (PDT) From: "Khem Raj" To: openembedded-core@lists.openembedded.org Cc: Rense Jacob , Rense , Khem Raj Subject: [PATCH] bind: Apply CVE-2020-8616.patch for bind 9.11.13 Date: Tue, 26 May 2020 13:51:04 -0700 Message-Id: <20200526205104.1296720-1-raj.khem@gmail.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Rense Jacob backport for nvd.nist.gov/vuln/detail/CVE-2020-8616 Signed-off-by: Rense Signed-off-by: Khem Raj --- .../bind/bind/CVE-2020-8616.patch | 221 ++++++++++++++++++ .../recipes-connectivity/bind/bind_9.11.13.bb | 1 + 2 files changed, 222 insertions(+) create mode 100644 meta/recipes-connectivity/bind/bind/CVE-2020-8616.patch diff --git a/meta/recipes-connectivity/bind/bind/CVE-2020-8616.patch b/meta/recipes-connectivity/bind/bind/CVE-2020-8616.patch new file mode 100644 index 0000000000..16ff86016b --- /dev/null +++ b/meta/recipes-connectivity/bind/bind/CVE-2020-8616.patch @@ -0,0 +1,221 @@ +backport for nvd.nist.gov/vuln/detail/CVE-2020-8616 + +Upstream-Status: Backport [downloads.isc.org/isc/bind9/9.11.19/patches/CVE-2020-8616.patch] + +Signed-off-by: Rense +Signed-off-by: Khem Raj + +Index: bind-9.11.13/lib/dns/adb.c +=================================================================== +--- bind-9.11.13.orig/lib/dns/adb.c ++++ bind-9.11.13/lib/dns/adb.c +@@ -404,16 +404,14 @@ static void log_quota(dns_adbentry_t *en + */ + #define FIND_WANTEVENT(fn) (((fn)->options & DNS_ADBFIND_WANTEVENT) != 0) + #define FIND_WANTEMPTYEVENT(fn) (((fn)->options & DNS_ADBFIND_EMPTYEVENT) != 0) +-#define FIND_AVOIDFETCHES(fn) (((fn)->options & DNS_ADBFIND_AVOIDFETCHES) \ +- != 0) +-#define FIND_STARTATZONE(fn) (((fn)->options & DNS_ADBFIND_STARTATZONE) \ +- != 0) +-#define FIND_HINTOK(fn) (((fn)->options & DNS_ADBFIND_HINTOK) != 0) +-#define FIND_GLUEOK(fn) (((fn)->options & DNS_ADBFIND_GLUEOK) != 0) +-#define FIND_HAS_ADDRS(fn) (!ISC_LIST_EMPTY((fn)->list)) +-#define FIND_RETURNLAME(fn) (((fn)->options & DNS_ADBFIND_RETURNLAME) != 0) +- +-/* ++#define FIND_AVOIDFETCHES(fn) (((fn)->options & DNS_ADBFIND_AVOIDFETCHES) != 0) ++#define FIND_STARTATZONE(fn) (((fn)->options & DNS_ADBFIND_STARTATZONE) != 0) ++#define FIND_HINTOK(fn) (((fn)->options & DNS_ADBFIND_HINTOK) != 0) ++#define FIND_GLUEOK(fn) (((fn)->options & DNS_ADBFIND_GLUEOK) != 0) ++#define FIND_HAS_ADDRS(fn) (!ISC_LIST_EMPTY((fn)->list)) ++#define FIND_RETURNLAME(fn) (((fn)->options & DNS_ADBFIND_RETURNLAME) != 0) ++#define FIND_NOFETCH(fn) (((fn)->options & DNS_ADBFIND_NOFETCH) != 0) ++/* + * These are currently used on simple unsigned ints, so they are + * not really associated with any particular type. + */ +@@ -3155,21 +3153,25 @@ dns_adb_createfind2(dns_adb_t *adb, isc_ + * Listen to negative cache hints, and don't start + * another query. + */ +- if (NCACHE_RESULT(result) || AUTH_NX(result)) ++ if (NCACHE_RESULT(result) || AUTH_NX(result)) { + goto fetch; +- +- if (!NAME_FETCH_V6(adbname)) ++ } ++ if (!NAME_FETCH_V6(adbname)) { + wanted_fetches |= DNS_ADBFIND_INET6; ++ } + } + + fetch: + if ((WANT_INET(wanted_addresses) && NAME_HAS_V4(adbname)) || + (WANT_INET6(wanted_addresses) && NAME_HAS_V6(adbname))) ++ { + have_address = true; +- else +- have_address = false; +- if (wanted_fetches != 0 && +- ! (FIND_AVOIDFETCHES(find) && have_address)) { ++ } else { ++ have_address = false; ++ } ++ if (wanted_fetches != 0 && !(FIND_AVOIDFETCHES(find) && have_address) && ++ !FIND_NOFETCH(find)) ++ { + /* + * We're missing at least one address family. Either the + * caller hasn't instructed us to avoid fetches, or we don't +@@ -3177,8 +3179,9 @@ dns_adb_createfind2(dns_adb_t *adb, isc_ + * be acceptable so we have to launch fetches. + */ + +- if (FIND_STARTATZONE(find)) ++ if (FIND_STARTATZONE(find)) { + start_at_zone = true; ++ } + + /* + * Start V4. +Index: bind-9.11.13/lib/dns/include/dns/adb.h +=================================================================== +--- bind-9.11.13.orig/lib/dns/include/dns/adb.h ++++ bind-9.11.13/lib/dns/include/dns/adb.h +@@ -209,6 +209,12 @@ struct dns_adbfind { + #define DNS_ADBFIND_OVERQUOTA 0x00000400 + + /*% ++ * Don't perform a fetch even if there are no address records available. ++ */ ++#define DNS_ADBFIND_NOFETCH 0x00000800 ++ ++ ++/*% + * The answers to queries come back as a list of these. + */ + struct dns_adbaddrinfo { +Index: bind-9.11.13/lib/dns/resolver.c +=================================================================== +--- bind-9.11.13.orig/lib/dns/resolver.c ++++ bind-9.11.13/lib/dns/resolver.c +@@ -172,6 +172,15 @@ + #define DEFAULT_MAX_QUERIES 75 + #endif + ++/* ++ * After NS_FAIL_LIMIT attempts to fetch a name server address, ++ * if the number of addresses in the NS RRset exceeds NS_RR_LIMIT, ++ * stop trying to fetch, in order to avoid wasting resources. ++ */ ++#define NS_FAIL_LIMIT 4 ++#define NS_RR_LIMIT 5 ++ ++ + /* Number of hash buckets for zone counters */ + #ifndef RES_DOMAIN_BUCKETS + #define RES_DOMAIN_BUCKETS 523 +@@ -3118,8 +3127,8 @@ sort_finds(dns_adbfindlist_t *findlist, + static void + findname(fetchctx_t *fctx, dns_name_t *name, in_port_t port, + unsigned int options, unsigned int flags, isc_stdtime_t now, +- bool *overquota, bool *need_alternate) +-{ ++ bool *overquota, bool *need_alternate, unsigned int *no_addresses) { ++ + dns_adbaddrinfo_t *ai; + dns_adbfind_t *find; + dns_resolver_t *res; +@@ -3207,7 +3216,13 @@ findname(fetchctx_t *fctx, dns_name_t *n + find->result_v6 != DNS_R_NXDOMAIN) || + (res->dispatches6 == NULL && + find->result_v4 != DNS_R_NXDOMAIN))) ++ { + *need_alternate = true; ++ } ++ if (no_addresses != NULL) { ++ (*no_addresses)++; ++ } ++ + } else { + if ((find->options & DNS_ADBFIND_OVERQUOTA) != 0) { + if (overquota != NULL) +@@ -3258,6 +3273,7 @@ fctx_getaddresses(fetchctx_t *fctx, bool + dns_rdata_ns_t ns; + bool need_alternate = false; + bool all_spilled = true; ++ unsigned int no_addresses = 0; + + FCTXTRACE5("getaddresses", "fctx->depth=", fctx->depth); + +@@ -3425,21 +3441,28 @@ fctx_getaddresses(fetchctx_t *fctx, bool + * Extract the name from the NS record. + */ + result = dns_rdata_tostruct(&rdata, &ns, NULL); +- if (result != ISC_R_SUCCESS) ++ if (result != ISC_R_SUCCESS) { + continue; ++ } ++ ++ if (no_addresses > NS_FAIL_LIMIT && ++ dns_rdataset_count(&fctx->nameservers) > NS_RR_LIMIT) ++ { ++ stdoptions |= DNS_ADBFIND_NOFETCH; ++ } ++ findname(fctx, &ns.name, 0, stdoptions, 0, now, &overquota, ++ &need_alternate, &no_addresses); + +- findname(fctx, &ns.name, 0, stdoptions, 0, now, +- &overquota, &need_alternate); + +- if (!overquota) ++ if (!overquota) { + all_spilled = false; +- ++ } + dns_rdata_reset(&rdata); + dns_rdata_freestruct(&ns); + } +- if (result != ISC_R_NOMORE) ++ if (result != ISC_R_NOMORE) { + return (result); +- ++ } + /* + * Do we need to use 6 to 4? + */ +@@ -3453,7 +3476,7 @@ fctx_getaddresses(fetchctx_t *fctx, bool + if (!a->isaddress) { + findname(fctx, &a->_u._n.name, a->_u._n.port, + stdoptions, FCTX_ADDRINFO_FORWARDER, +- now, NULL, NULL); ++ now, NULL, NULL, NULL); + continue; + } + if (isc_sockaddr_pf(&a->_u.addr) != family) +@@ -3815,16 +3838,15 @@ fctx_try(fetchctx_t *fctx, bool retrying + } + } + +- if (dns_name_countlabels(&fctx->domain) > 2) { +- result = isc_counter_increment(fctx->qc); +- if (result != ISC_R_SUCCESS) { +- isc_log_write(dns_lctx, DNS_LOGCATEGORY_RESOLVER, +- DNS_LOGMODULE_RESOLVER, ISC_LOG_DEBUG(3), +- "exceeded max queries resolving '%s'", +- fctx->info); +- fctx_done(fctx, DNS_R_SERVFAIL, __LINE__); +- return; +- } ++ ++ result = isc_counter_increment(fctx->qc); ++ if (result != ISC_R_SUCCESS) { ++ isc_log_write(dns_lctx, DNS_LOGCATEGORY_RESOLVER, ++ DNS_LOGMODULE_RESOLVER, ISC_LOG_DEBUG(3), ++ "exceeded max queries resolving '%s'", ++ fctx->info); ++ fctx_done(fctx, DNS_R_SERVFAIL, __LINE__); ++ return; + } + + bucketnum = fctx->bucketnum; diff --git a/meta/recipes-connectivity/bind/bind_9.11.13.bb b/meta/recipes-connectivity/bind/bind_9.11.13.bb index 4e64171cc1..e81678583d 100644 --- a/meta/recipes-connectivity/bind/bind_9.11.13.bb +++ b/meta/recipes-connectivity/bind/bind_9.11.13.bb @@ -18,6 +18,7 @@ SRC_URI = "https://ftp.isc.org/isc/bind9/${PV}/${BPN}-${PV}.tar.gz \ file://0001-configure.in-remove-useless-L-use_openssl-lib.patch \ file://0001-named-lwresd-V-and-start-log-hide-build-options.patch \ file://0001-avoid-start-failure-with-bind-user.patch \ + file://CVE-2020-8616.patch \ " SRC_URI[md5sum] = "17de0d024ab1eac377f1c2854dc25057" -- 2.26.2