From: Tejun Heo Date: Thu, 28 May 2020 14:03:57 +0000 Subject: Re: =?utf-8?B?5Zue5aSNOiBbUEFUQ0ggdjU=?= =?utf-8?Q?=5D?= workqueue: Remove unnecessary kfree() call Message-Id: <20200528140357.GL83516@mtj.thefacebook.com> List-Id: References: <20200527075715.36849-1-qiang.zhang@windriver.com> <284c7851-4e89-a00f-a2e6-aa8e2e1f3fce@web.de> <20200528095703.GH30374@kadam> <20200528122545.GP22511@kadam> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Lai Jiangshan Cc: Dan Carpenter , "Zhang, Qiang" , Markus Elfring , "linux-kernel@vger.kernel.org" , "kernel-janitors@vger.kernel.org" Hello, On Thu, May 28, 2020 at 09:27:03PM +0800, Lai Jiangshan wrote: > wq owns the ultimate or permanent references to itself by > owning references to wq->numa_pwq_tbl[node], wq->dfl_pwq. > The pwq's references keep the pwq in wq->pwqs. Yeah, regardless of who puts a wq the last time, the base reference is put by destroy_workqueue() and thus it's guaranteed that a wq can't be rcu freed without going through destroy_workqueue(). lol I'm undoing the revert. Thanks. -- tejun