From: Michal Hocko Subject: Re: mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page Date: Thu, 28 May 2020 16:59:42 +0200 Message-ID: <20200528145942.GF27484@dhcp22.suse.cz> References: <20200520190906.GA558281@chrisdown.name> <20200521095515.GK6462@dhcp22.suse.cz> <20200521105801.GL6462@dhcp22.suse.cz> <20200521124444.GP6462@dhcp22.suse.cz> <20200521191746.GB815980@cmpxchg.org> <20200521215855.GB815153@cmpxchg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=HvdKpHF042iTNApEGGudMnbcuPPZ+JOhqsO7H3d0iMc=; b=YNo9RMQWjgTv6pi8yI0Yw7xRSs +KMTzG8I3B0x/hkZHff4X2VRA/FSFsNzBo/r6tWHG9f+KZyjZmfcLzAkb5vWDkefZVi3N9t9HwYXb yOV6785yqAD/QeJ3XzGHgHRX3VR+zUgSR18pnQiFPOVk7sR7dGnIbGAIM4otrgvzT0WE=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=HvdKpHF042iTNApEGGudMnbcuPPZ+JOhqsO7H3d0iMc=; b=LzUyGqS27pvGzHNHpdaklyAc2I F+4SYsCRTfTipeYRIYAQg86uxcWMQKa1WTHCftSvfPkv/Gifsdg6auZmmSq0n879WI0lJnVV7Gl1E WnrmM5rrzjc6Sly13gP3Luq30nZTWCxqmV5W4eKz05vLKWyhuPMaRbJ4GYTbag37TroA=; Content-Disposition: inline In-Reply-To: <20200521215855.GB815153@cmpxchg.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Johannes Weiner Cc: lkft-triage@lists.linaro.org, linux-mm , Yafang Shao , Andreas Dilger , Cgroups , Andrea Arcangeli , Anders Roxell , Naresh Kamboju , Hugh Dickins , Matthew Wilcox , Linux-Next Mailing List , linux-ext4 , Arnd Bergmann , linux-block , Jaegeuk Kim , Theodore Ts'o , Chris Down , open list , "Linux F2FS DEV, Mailing List" , Andrew Morton , Roman Gushchin [Sorry for a late reply - was offline for few days] On Thu 21-05-20 17:58:55, Johannes Weiner wrote: > On Thu, May 21, 2020 at 01:06:28PM -0700, Hugh Dickins wrote: [...] > >From d9e7ed15d1c9248a3fd99e35e82437549154dac7 Mon Sep 17 00:00:00 2001 > From: Johannes Weiner > Date: Thu, 21 May 2020 17:44:25 -0400 > Subject: [PATCH] mm: memcontrol: prepare swap controller setup for integration > fix > > Fix crash with cgroup_disable=memory: > > > > > > + mkfs -t ext4 /dev/disk/by-id/ata-TOSHIBA_MG04ACA100N_Y8NRK0BPF6XF > > > > > mke2fs 1.43.8 (1-Jan-2018) > > > > > Creating filesystem with 244190646 4k blocks and 61054976 inodes > > > > > Filesystem UUID: 3bb1a285-2cb4-44b4-b6e8-62548f3ac620 > > > > > Superblock backups stored on blocks: > > > > > 32768, 98304, 163840, 229376, 294912, 819200, 884736, 1605632, 2654208, > > > > > 4096000, 7962624, 11239424, 20480000, 23887872, 71663616, 78675968, > > > > > 102400000, 214990848 > > > > > Allocating group tables: 0/7453 done > > > > > Writing inode tables: 0/7453 done > > > > > Creating journal (262144 blocks): [ 35.502102] BUG: kernel NULL > > > > > pointer dereference, address: 000000c8 > > > > > [ 35.508372] #PF: supervisor read access in kernel mode > > > > > [ 35.513506] #PF: error_code(0x0000) - not-present page > > > > > [ 35.518638] *pde = 00000000 > > > > > [ 35.521514] Oops: 0000 [#1] SMP > > > > > [ 35.524652] CPU: 0 PID: 145 Comm: kswapd0 Not tainted > > > > > 5.7.0-rc6-next-20200519+ #1 > > > > > [ 35.532121] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS > > > > > 2.2 05/23/2018 > > > > > [ 35.539507] EIP: mem_cgroup_get_nr_swap_pages+0x28/0x60 > > Swap accounting used to be implied-disabled when the cgroup controller > was disabled. Restore that for the new cgroup_memory_noswap, so that > we bail out of this function instead of dereferencing a NULL memcg. > > Reported-by: Naresh Kamboju > Debugged-by: Hugh Dickins > Debugged-by: Michal Hocko > Signed-off-by: Johannes Weiner Yes this looks better. I hope to get to your series soon to have the full picture finally. > --- > mm/memcontrol.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 3e000a316b59..e3b785d6e771 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -7075,7 +7075,11 @@ static struct cftype memsw_files[] = { > > static int __init mem_cgroup_swap_init(void) > { > - if (mem_cgroup_disabled() || cgroup_memory_noswap) > + /* No memory control -> no swap control */ > + if (mem_cgroup_disabled()) > + cgroup_memory_noswap = true; > + > + if (cgroup_memory_noswap) > return 0; > > WARN_ON(cgroup_add_dfl_cftypes(&memory_cgrp_subsys, swap_files)); > -- > 2.26.2 -- Michal Hocko SUSE Labs