Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10DC5C433DF for ; Fri, 29 May 2020 23:45:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D800720810 for ; Fri, 29 May 2020 23:45:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728493AbgE2XpH (ORCPT ); Fri, 29 May 2020 19:45:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728142AbgE2XpH (ORCPT ); Fri, 29 May 2020 19:45:07 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B50FC03E969 for ; Fri, 29 May 2020 16:45:07 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id E0696128683F5; Fri, 29 May 2020 16:45:06 -0700 (PDT) Date: Fri, 29 May 2020 16:45:06 -0700 (PDT) Message-Id: <20200529.164506.2200622965835884094.davem@davemloft.net> To: olteanv@gmail.com Cc: andrew@lunn.ch, f.fainelli@gmail.com, vivien.didelot@gmail.com, netdev@vger.kernel.org Subject: Re: [PATCH net] net: dsa: sja1105: fix port mirroring for P/Q/R/S From: David Miller In-Reply-To: <20200527164006.1080903-1-olteanv@gmail.com> References: <20200527164006.1080903-1-olteanv@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 29 May 2020 16:45:07 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Vladimir Oltean Date: Wed, 27 May 2020 19:40:06 +0300 > From: Vladimir Oltean > > The dynamic configuration interface for the General Params and the L2 > Lookup Params tables was copy-pasted between E/T devices and P/Q/R/S > devices. Nonetheless, these interfaces are bitwise different (and not to > mention, located at different SPI addresses). > > The driver is using dynamic reconfiguration of the General Parameters > table for the port mirroring feature, which was therefore broken on > P/Q/R/S. > > Note that I don't think this patch can be backported very far to stable > trees (since it conflicts with some other development done since the > introduction of the driver). > > Fixes: 8aa9ebccae87 ("net: dsa: Introduce driver for NXP SJA1105 5-port L2 switch") > Signed-off-by: Vladimir Oltean Please fix the build errors reported by the kbuild robot.