Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB7E7C433E0 for ; Tue, 2 Jun 2020 10:00:30 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B56AD20679 for ; Tue, 2 Jun 2020 10:00:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B56AD20679 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jg3iD-0000Tf-9I; Tue, 02 Jun 2020 10:00:01 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jg3iC-0000Ta-0N for xen-devel@lists.xenproject.org; Tue, 02 Jun 2020 10:00:00 +0000 X-Inumbo-ID: d12468b8-a4b7-11ea-abc2-12813bfff9fa Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d12468b8-a4b7-11ea-abc2-12813bfff9fa; Tue, 02 Jun 2020 09:59:58 +0000 (UTC) Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: d2Mu1LQtWWzeflpB18rpXYYVCxEvmvsmgsp/f2Lnpo5NKs3sdUyh4idN4VlKV1ycu5slUKKX1n TKLMTKpnhcp3HfjlB0IcJ8G1ZNKtfxj2VhPwf9nLzxrqWiVNM/3O1ktRB8YbhdaPky+Vg7Z6K2 jvRSdE8LO9a7iDggTjqiEdkcFT4ZHB+jwbPL6yUfitL0baH/GKNrdRdsshgumvbnTEUnYM4qql sgMvbZFBvKLF88mxuZoLDQT8aasDWXN4Cuf1DJIQJAqJQYiUGGpzGN0lsCBRekpqa2dJn506MH pnI= X-SBRS: 2.7 X-MesageID: 18998554 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.73,463,1583211600"; d="scan'208";a="18998554" Date: Tue, 2 Jun 2020 11:59:44 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Wei Liu Subject: Re: [[PATCH v2 for-4.14]] m4: use test instead of [] Message-ID: <20200602092447.GV1195@Air-de-Roger> References: <20200602090138.28656-1-wl@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200602090138.28656-1-wl@xen.org> X-ClientProxiedBy: AMSPEX02CAS02.citrite.net (10.69.22.113) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Xen Development List , paul@xen.org, Ian Jackson , Bertrand Marquis Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" There's a double [] enclosure in the subject On Tue, Jun 02, 2020 at 09:01:38AM +0000, Wei Liu wrote: > It is reported that [] was removed by autoconf, which caused the > following error: > > ./configure: line 4681: -z: command not found > > Switch to test. That's what is used throughout our configure scripts. > Also put the variable expansion in quotes. > > Signed-off-by: Wei Liu > Reported-by: Bertrand Marquis > Fixes: 8a6b1665d987 ("configure: also add EXTRA_PREFIX to {CPP/LD}FLAGS") > Signed-off-by: Wei Liu There's a double SoB ;) Reviewed-by: Roger Pau Monné Thanks for taking care of this.