From: Tom Rini Date: Tue, 2 Jun 2020 09:02:17 -0400 Subject: [PATCH v1 1/2] net: cortina_ni: Addd eth support for Cortina Access CAxxxx SoCs In-Reply-To: <1591065866-5818-1-git-send-email-alex.nemirovsky@cortina-access.com> References: <1591065866-5818-1-git-send-email-alex.nemirovsky@cortina-access.com> Message-ID: <20200602130217.GB21630@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Jun 01, 2020 at 07:44:25PM -0700, Alex Nemirovsky wrote: > From: Aaron Tseng > > Add Cortina Access Ethernet device driver for CAxxxx SoCs. > This driver supports both legacy and DM_ETH network models. > > Signed-off-by: Aaron Tseng > Signed-off-by: Alex Nemirovsky > > CC: Joe Hershberger > CC: Abbie Chang > CC: Tom Rini [snip] > +#define HEADER_A_SIZE 8 > +#define CORTINA_NI_DBG 1 > +/*define CORTINA_NI_DBG if individual rx,tx,init needs to be called */ We have pr_debug, etc, please use those and not a custom debug defiine. > +#ifdef CONFIG_DM_ETH > +#if CORTINA_NI_DBG > +static struct udevice *dbg_dev; > +#endif > +static struct udevice *curr_dev; > +#else The deadline for drivers to convert to DM for ethernet is v2020.07. Please rework to not introduce any legacy mode support. Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: