From: Mike Rapoport Date: Thu, 04 Jun 2020 06:18:05 +0000 Subject: Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice Message-Id: <20200604061805.GA202650@kernel.org> List-Id: References: <20200518184843.3029640-1-ira.weiny@intel.com> <20200519165422.GA5838@roeck-us.net> <20200519184031.GB3356843@iweiny-DESK2.sc.intel.com> <20200519194215.GA71941@roeck-us.net> <20200520051315.GA3660833@iweiny-DESK2.sc.intel.com> <20200521174250.GB176262@iweiny-DESK2.sc.intel.com> <20200603135736.e7b5ded0082a81ae6d9067a0@linux-foundation.org> <20200603211416.GA1740285@iweiny-DESK2.sc.intel.com> <3538c8ad-674e-d310-d870-4ef6888092ed@roeck-us.net> In-Reply-To: <3538c8ad-674e-d310-d870-4ef6888092ed@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Guenter Roeck Cc: Peter Zijlstra , Dave Hansen , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, "James E.J. Bottomley" , Max Filippov , Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, Ira Weiny , Dan Williams , Helge Deller , x86@kernel.org, linux-csky@vger.kernel.org, Christoph Hellwig , Ingo Molnar , linux-snps-arc@lists.infradead.org, linux-xtensa@linux-xtensa.org, Borislav Petkov , Al Viro , Andy Lutomirski , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Chris Zankel , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Koenig , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" On Wed, Jun 03, 2020 at 04:44:17PM -0700, Guenter Roeck wrote: > On 6/3/20 2:14 PM, Ira Weiny wrote: > > On Wed, Jun 03, 2020 at 01:57:36PM -0700, Andrew Morton wrote: > >> On Thu, 21 May 2020 10:42:50 -0700 Ira Weiny wrote: > >> > >>>>> > >>>>> Actually it occurs to me that the patch consolidating kmap_prot is odd for > >>>>> sparc 32 bit... > >>>>> > >>>>> Its a long shot but could you try reverting this patch? > >>>>> > >>>>> 4ea7d2419e3f kmap: consolidate kmap_prot definitions > >>>>> > >>>> > >>>> That is not easy to revert, unfortunately, due to several follow-up patches. > >>> > >>> I have gotten your sparc tests to run and they all pass... > >>> > >>> 08:10:34 > ../linux-build-test/rootfs/sparc/run-qemu-sparc.sh > >>> Build reference: v5.7-rc4-17-g852b6f2edc0f > >>> > >>> Building sparc32:SPARCClassic:nosmp:scsi:hd ... running ......... passed > >>> Building sparc32:SPARCbook:nosmp:scsi:cd ... running ......... passed > >>> Building sparc32:LX:nosmp:noapc:scsi:hd ... running ......... passed > >>> Building sparc32:SS-4:nosmp:initrd ... running ......... passed > >>> Building sparc32:SS-5:nosmp:scsi:hd ... running ......... passed > >>> Building sparc32:SS-10:nosmp:scsi:cd ... running ......... passed > >>> Building sparc32:SS-20:nosmp:scsi:hd ... running ......... passed > >>> Building sparc32:SS-600MP:nosmp:scsi:hd ... running ......... passed > >>> Building sparc32:Voyager:nosmp:noapc:scsi:hd ... running ......... passed > >>> Building sparc32:SS-4:smp:scsi:hd ... running ......... passed > >>> Building sparc32:SS-5:smp:scsi:cd ... running ......... passed > >>> Building sparc32:SS-10:smp:scsi:hd ... running ......... passed > >>> Building sparc32:SS-20:smp:scsi:hd ... running ......... passed > >>> Building sparc32:SS-600MP:smp:scsi:hd ... running ......... passed > >>> Building sparc32:Voyager:smp:noapc:scsi:hd ... running ......... passed > >>> > >>> Is there another test I need to run? > >> > >> This all petered out, but as I understand it, this patchset still might > >> have issues on various architectures. > >> > >> Can folks please provide an update on the testing status? > > > > I believe the tests were failing for Guenter due to another patch set...[1] > > > > My tests with just this series are working. > > > >>From my understanding the other failures were unrelated.[2] > > > > > > I've checked the patch above on top of the mmots which already has > > Ira's patches and it booted fine. I've used sparc32_defconfig to build > > the kernel and qemu-system-sparc with default machine and CPU. > > > > > > Mike, am I wrong? Do you think the kmap() patches are still causing issues? sparc32 UP and microblaze work for me with next-20200603, but I didn't test other architectures. > For my part, all I can say is that -next is in pretty bad shape right now. > The summary of my tests says: > > Build results: > total: 151 pass: 130 fail: 21 > Qemu test results: > total: 430 pass: 375 fail: 55 > > sparc32 smp images in next-20200603 still crash for me with a spinlock > recursion. I think this is because Will's fixes [1] are not yet in -next. > s390 images hang early in boot. Several others (alpha, arm64, > various ppc) don't even compile. I can run some more bisects over time, > but this is becoming a full-time job :-(. > > Guenter [1] https://lore.kernel.org/lkml/20200526173302.377-1-will@kernel.org -- Sincerely yours, Mike.