Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4700C433DF for ; Thu, 4 Jun 2020 09:17:49 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B51D2074B for ; Thu, 4 Jun 2020 09:17:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="S2z3JZYh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B51D2074B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44862 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgm0S-0004Tj-T5 for qemu-devel@archiver.kernel.org; Thu, 04 Jun 2020 05:17:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54704) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jglzi-0003UZ-LW for qemu-devel@nongnu.org; Thu, 04 Jun 2020 05:17:02 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:44754 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jglzh-00074q-W8 for qemu-devel@nongnu.org; Thu, 04 Jun 2020 05:17:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591262221; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oOX7V94jHlPcHZgyx6L+n4UFnr2O4M11f83R9g3VSvk=; b=S2z3JZYh/W1HJQhh3LZ5w1IeHCnXqNG67SNlrGsywRrDQeLrtejEWPOtzme9TJrYGs7IdS XDQnLQ3hLJcfgxYkNmM/RDxQYfkoJbcjoevoV6ijSbd8gyH6jnYFlBIKc1AKUPzYps//md 0ujPsU15lttTNVUnw7nrxQg/o4XOU58= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-234-_7ZY3cOeP0a6NJGkpTZ4Sw-1; Thu, 04 Jun 2020 05:16:57 -0400 X-MC-Unique: _7ZY3cOeP0a6NJGkpTZ4Sw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 45CBF800C78; Thu, 4 Jun 2020 09:16:56 +0000 (UTC) Received: from angien.pipo.sk (unknown [10.40.208.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F12702DE7D; Thu, 4 Jun 2020 09:16:53 +0000 (UTC) Date: Thu, 4 Jun 2020 11:16:51 +0200 From: Peter Krempa To: Kevin Wolf Subject: Re: [PATCH RFC v2 1/5] block: add bitmap-populate job Message-ID: <20200604091651.GF2995787@angien.pipo.sk> References: <20200514034922.24834-1-jsnow@redhat.com> <20200514034922.24834-2-jsnow@redhat.com> <20200604091231.GC4512@linux.fritz.box> MIME-Version: 1.0 In-Reply-To: <20200604091231.GC4512@linux.fritz.box> X-PGP-Key-ID: 0xD018682B X-PGP-Key-Fingerprint: D294 FF38 A6A2 BF40 6C75 5DEF 36EC 16AC D018 682B User-Agent: Mutt/1.13.4 (2020-02-15) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=205.139.110.120; envelope-from=pkrempa@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/04 01:12:15 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vsementsov@virtuozzo.com, Eduardo Habkost , qemu-block@nongnu.org, qemu-devel@nongnu.org, Markus Armbruster , Cleber Rosa , Max Reitz , John Snow Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Jun 04, 2020 at 11:12:31 +0200, Kevin Wolf wrote: > Am 18.05.2020 um 22:49 hat Eric Blake geschrieben: > > > + > > > + /* NB: new bitmap is anonymous and enabled */ > > > + cluster_size = bdrv_dirty_bitmap_granularity(target_bitmap); > > > + new_bitmap = bdrv_create_dirty_bitmap(bs, cluster_size, NULL, errp); > > > + if (!new_bitmap) { > > > + return NULL; > > > + } > > > > This means if the guest writes to the disk while the job is ongoing, the > > bitmap will be updated to mark that portion of the bitmap as set, even if it > > was not allocated at the time the job started. But then again, the guest > > writes are causing allocation, so this seems like the right thing to do. > > Is the target bitmap active at the same time, i.e. will it get the > correct information only from new_bitmap or are the bits already set in > it anyway? Yes, libvirt plans to use it with an active non-persistent bitmap which will in subsequent steps be merged into others. The bitmap is added in the same transaction. The bitmap must be active, because we need to wait for the block jobs to finish before it becomes usable and thus can't sequence in other operations until later.