Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F13AC433DF for ; Fri, 5 Jun 2020 08:47:19 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 27E4120772 for ; Fri, 5 Jun 2020 08:47:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 27E4120772 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jh807-0006vb-8r; Fri, 05 Jun 2020 08:46:55 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jh806-0006vW-Ba for xen-devel@lists.xenproject.org; Fri, 05 Jun 2020 08:46:54 +0000 X-Inumbo-ID: 1a5c33f0-a709-11ea-af8e-12813bfff9fa Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1a5c33f0-a709-11ea-af8e-12813bfff9fa; Fri, 05 Jun 2020 08:46:53 +0000 (UTC) Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: f8OXVohKE4k/nmQym3ANfLiLOliTUROI64UtVoj82JVSSfs3jUgD3fWlSRFUsScnhLIKYjUuxg 7h0yEHX13DAaxvE7FC2p2EE09WVvZuYvLa6zm8bsKuIiQgon3gFrxqu8zVj+9Yjvu0KKg7s57i /zU6ABQm9BC8mGaOLXbp9YnBKNU5bts4rNU4Ud9u/qP6TvwN/1LUaueUCB2vOEQ0TPMvUGhocd N++covbL6KVNXQGjoiunLDY7kGbVQvyjnc6Oolglr6IGcYtifpcJfgvhCkscObBkNvjGywHdmz /aI= X-SBRS: 2.7 X-MesageID: 19553588 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.73,475,1583211600"; d="scan'208";a="19553588" Date: Fri, 5 Jun 2020 10:46:44 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Subject: Re: [PATCH] x86/Intel: insert Ice Lake and Comet Lake model numbers Message-ID: <20200605084644.GJ1195@Air-de-Roger> References: <20200605080216.GI1195@Air-de-Roger> <32c4cdf7-0fdd-8b12-ee42-dfe8fe096935@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <32c4cdf7-0fdd-8b12-ee42-dfe8fe096935@suse.com> X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-devel@lists.xenproject.org" , Paul Durrant , Wei Liu , Andrew Cooper Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Fri, Jun 05, 2020 at 10:10:01AM +0200, Jan Beulich wrote: > On 05.06.2020 10:02, Roger Pau Monné wrote: > > On Fri, Jun 05, 2020 at 09:51:09AM +0200, Jan Beulich wrote: > >> Both match prior generation processors as far as LBR and C-state MSRs > >> go (SDM rev 072) as well as applicability of the if_pschange_mc erratum > >> (recent spec updates). > >> > >> Signed-off-by: Jan Beulich > >> --- > >> Such changes having been subject to backporting in the past, this > >> change may want considering for 4.14. > >> --- > >> I'm leaving alone spec_ctrl.c, albeit there's a scary looking erratum > >> for Ice Lake indicating that MDS_NO may wrongly be set. But this is > >> apparently addressed by ucode update, so we may not need to deal with > >> it in software. > >> > >> --- a/xen/arch/x86/acpi/cpu_idle.c > >> +++ b/xen/arch/x86/acpi/cpu_idle.c > > > > What about mwait-idle? I guess we pick that from Linux and no patch > > has been added so far? > > Correct. I've looked at recent history there, and I'm uncertain they'll > add further models there. They look to prefer to use ACPI _CST now again > with, as it seems, not overly much of a difference to the ACPI driver > (which, if we were to follow, I'd rather see us integrate there). Urg, OK, that's a shame as using mwait-idle was IMO better from a Xen PoV as we didn't rely on dom0 in order to discover C states. I wonder if we could continue to update mwait-idle on our own for newer models. FWIW, wikichip also lists 6c and 6a [0] as Ice Lake Server model versions, but I'm not sure if this has been confirmed in any way? Roger. [0] https://en.wikichip.org/wiki/intel/cpuid#Big_Cores_.28Server.29