From: Tom Rini Date: Fri, 5 Jun 2020 08:30:16 -0400 Subject: [PATCH] mmc: omap_hsmmc: Add guards around omap_hsmmc_get_cfg() In-Reply-To: <2813757b-64ca-5849-8dc6-31ff382ab021@ti.com> References: <20200604200355.5174-1-trini@konsulko.com> <2813757b-64ca-5849-8dc6-31ff382ab021@ti.com> Message-ID: <20200605123016.GB32287@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, Jun 05, 2020 at 10:16:53AM +0530, Lokesh Vutla wrote: > > > On 05/06/20 1:33 am, Tom Rini wrote: > > We only call the function omap_hsmmc_get_cfg in the case of OMAP34XX or > > when we have to iodelay recalibration. Add guards for these checks as > > clang will otherwise warn. > > > > Cc: Peng Fan > > Cc: Lokesh Vutla > > Signed-off-by: Tom Rini > > Reviewed-by: Lokesh Vutla > > > --- > > Aside, Lokesh, can you please add drivers/mmc/omap_hsmmc.c to the > > general TI entry MAINTAINERS entry? Thanks! > > We have a subsystem maintainer for MMC. IIUC, all the patches should go through > subsystem if one is available, so I intentionally did not add omap_hsmmc under > TI. Is my understanding wrong? Yes. While there is a subsystem maintainer, they aren't going to know the IP-block quirks as well as the custodian for a given SoC, so individual drivers should be listed under the SoC/arch entry as well. get_maintainers.pl will list both when queried. Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: