Received: from mail-qv1-f67.google.com (mail-qv1-f67.google.com [209.85.219.67]) by mx.groups.io with SMTP id smtpd.web11.33262.1591631393412774759 for ; Mon, 08 Jun 2020 08:49:53 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kudzu-us.20150623.gappssmtp.com header.s=20150623 header.b=G9UM0wfb; spf=none, err=permanent DNS error (domain: kudzu.us, ip: 209.85.219.67, mailfrom: jdmason@kudzu.us) Received: by mail-qv1-f67.google.com with SMTP id cv17so8521805qvb.13 for ; Mon, 08 Jun 2020 08:49:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kudzu-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=0OzT/j6tTKySBXCmCgxx25QJ6rfyKIrf0Q5I8SJgFYo=; b=G9UM0wfbwz9QTM11k234+mYRz4WfTWL5C11HrpfNbhhegaiX3E3VoV5danrbpsTRHA pjnaJByhDsJYSrGpWrkGuBApM3DQr4VPFPtgep87xdNjyyPb4Hw/nWehs4/oVpx9G2gQ WcIjB4ryXfmjqU26XBQ+mvBM+Pp/yOV2zfaxaTYlARdi/C8wqPh2IRTGUC4L0MAFTx2z vlHUrydPbVT+gGvOuBpFZozZq4fct6F/HscYA+yesjlrml0Cx3BzgILHclLjUa7mYfyy 8hyrEL6mbFr4973gOQR3PKqOxhes0c/fGPWDTY4kAp00j0zgisiMwcltXYYWpMtW7K+0 7oFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=0OzT/j6tTKySBXCmCgxx25QJ6rfyKIrf0Q5I8SJgFYo=; b=q8JZvoFy8SYvgYoMTto6oQCLbrjli3fUoe1zSWoI92FasFiozGGuwoqzp08PJ8ztw/ m6fgCzNr20VZClI/VUBSCsdgPXJaeC+eXE/0aShzfYoCw8KtD+rs4JOkMAf8w1ALaGbJ pI0SP9gCDKvIDQLwhdxFtRJMn9CSBCNstwSmf4GMDGjpgOhIuxKWoYWTLEfNSR+Z7OIm zAv94ruSu3bqg8I37EBtWbz4kNcT4XrejegHrn3bL/Q83Q+1vT4Pad4OUm9K3I7bJtot +Lz8CKSyh76Pd/k8MC5oHXDqgglnoGjVCyfthEmTRr8ghWO4s19TNFTf+IbYXFizYaXe 8I/A== X-Gm-Message-State: AOAM532egHNq7Ah4nFhEK3y7zY2jzRBYEG8RqiCfPXSMJj2kdbtRFab+ dzcR4AhOlg2uqW8kVB7qxj80rQ== X-Google-Smtp-Source: ABdhPJy/Ws888D+rapqOmVLuoO5HYhK77YmZDcbzR5z4nCekKPsF4gwT3APDfv0Coht6o6CzGVka9A== X-Received: by 2002:a0c:d444:: with SMTP id r4mr22753245qvh.67.1591631392464; Mon, 08 Jun 2020 08:49:52 -0700 (PDT) Return-Path: Received: from kudzu.us ([2605:a601:a61a:4700:b9b3:35e6:b1bd:2c87]) by smtp.gmail.com with ESMTPSA id m6sm7170271qkk.4.2020.06.08.08.49.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 08:49:52 -0700 (PDT) Date: Mon, 8 Jun 2020 11:49:50 -0400 From: "Jon Mason" To: Khasim Mohammed Cc: meta-arm@lists.yoctoproject.org, nd@arm.com Subject: Re: [meta-arm] [PATCH] arm-bsp: Add trusted firmware support for N1SDP Message-ID: <20200608154950.GD15959@kudzu.us> References: <20200602165152.27514-1-khasim.mohammed@arm.com> MIME-Version: 1.0 In-Reply-To: <20200602165152.27514-1-khasim.mohammed@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 02, 2020 at 05:51:52PM +0100, Khasim Mohammed wrote: > - Add new bbappend to fetch tfa ver 2.2 required for N1SDP > - Apply additional patch required for N1SDP > - Update machine conf to add image dependency for > trusted firmware component > > Issue-Id: PLATFORMS-3134 > Change-Id: Ibf593c1818c9ea08acf71c6b5b80abc4aca79723 > Signed-off-by: Khasim Syed Mohammed Pulled into master Thanks, Jon > --- > meta-arm-bsp/conf/machine/n1sdp.conf | 6 +++ > ...able-workaround-for-N1-Erratum-13157.patch | 46 +++++++++++++++++++ > .../trusted-firmware-a-n1sdp.inc | 13 ++++++ > .../trusted-firmware-a_2.2.bbappend | 11 +++++ > 4 files changed, 76 insertions(+) > create mode 100644 meta-arm-bsp/recipes-bsp/trusted-firmware-a/files/n1sdp/0001-n1sdp-arm-tf-disable-workaround-for-N1-Erratum-13157.patch > create mode 100644 meta-arm-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a-n1sdp.inc > create mode 100644 meta-arm-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a_2.2.bbappend > > diff --git a/meta-arm-bsp/conf/machine/n1sdp.conf b/meta-arm-bsp/conf/machine/n1sdp.conf > index 5fddcad..133fb89 100644 > --- a/meta-arm-bsp/conf/machine/n1sdp.conf > +++ b/meta-arm-bsp/conf/machine/n1sdp.conf > @@ -21,3 +21,9 @@ PREFERRED_VERSION_linux-linaro-arm ?= "5.4%" > > # RTL8168E Gigabit Ethernet Controller is attached to the PCIe interface > MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "linux-firmware-rtl8168" > + > +# Trusted firmware v2.2 version > +PREFERRED_PROVIDER_virtual/trusted-firmware-a ?= "trusted-firmware-a" > +PREFERRED_VERSION_trusted-firmware-a ?= "2.2%" > + > +EXTRA_IMAGEDEPENDS += "virtual/trusted-firmware-a" > diff --git a/meta-arm-bsp/recipes-bsp/trusted-firmware-a/files/n1sdp/0001-n1sdp-arm-tf-disable-workaround-for-N1-Erratum-13157.patch b/meta-arm-bsp/recipes-bsp/trusted-firmware-a/files/n1sdp/0001-n1sdp-arm-tf-disable-workaround-for-N1-Erratum-13157.patch > new file mode 100644 > index 0000000..53a6616 > --- /dev/null > +++ b/meta-arm-bsp/recipes-bsp/trusted-firmware-a/files/n1sdp/0001-n1sdp-arm-tf-disable-workaround-for-N1-Erratum-13157.patch > @@ -0,0 +1,46 @@ > +From 76847eb46e77d094eb8611760dd1ab880f617321 Mon Sep 17 00:00:00 2001 > +From: James Yang > +Date: Wed, 4 Sep 2019 10:49:45 -0500 > +Subject: [PATCH] n1sdp/arm-tf: disable workaround for N1 Erratum 1315703 and > + Spectre v4 > + > +This patch disables the workaround for Erratum 1315703 so that the N1 CPU > +performance in the N1 SDP better reflects that of released versions of the > +N1 for software that does not require mitigation for Spectre Variant 4. > + > +N1 SDP uses N1 version r1p0, which is affected by Erratum 1315703, which > +is fixed in N1 r3p1. The workaround for r1p0 disables the CPU performance > +feature of bypassing of stores by younger loads. This can significantly > +affect performance. The Erratum is classified "Cat A (Rare)" and requires > +a specific sequence of events to occur. > + > +Disabling this CPU performance feature is also the mitigation for Spectre > +Variant 4 (CVE-2018-3639). On CPUs that provide the PSTATE.SBSS feature, > +the OS selectively applies the mitigation only to programs that require it, > +leaving the performance of other programs unaffected. However, N1 r1p0 > +does not have the PSTATE.SBSS feature (which is introduced in N1 r3p1), and > +Arm-TF does not provide the interface to to dynamically disable the CPU > +performance feature. Therefore, applying the workaround penalizes ALL > +software running on N1 SDP, including those that do not require mitigation. > + > +This patch is meant for performance evaluation purposes ONLY and should not > +be used for software that requires a seccomp computing environment. > + > +Signed-off-by: James Yang > +--- > + plat/arm/board/n1sdp/platform.mk | 2 ++ > + 1 file changed, 2 insertions(+) > + > +diff --git a/plat/arm/board/n1sdp/platform.mk b/plat/arm/board/n1sdp/platform.mk > +index 986bd70a..7e30c857 100644 > +--- a/plat/arm/board/n1sdp/platform.mk > ++++ b/plat/arm/board/n1sdp/platform.mk > +@@ -66,3 +66,5 @@ include plat/arm/common/arm_common.mk > + include plat/arm/css/common/css_common.mk > + include plat/arm/board/common/board_common.mk > + > ++# N1SDP: disable workaround for Errata 1315703 and global Spectre v4 mitigation > ++override ERRATA_N1_1315703 := 0 > +-- > +2.17.1 > + > diff --git a/meta-arm-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a-n1sdp.inc b/meta-arm-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a-n1sdp.inc > new file mode 100644 > index 0000000..ad4af5a > --- /dev/null > +++ b/meta-arm-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a-n1sdp.inc > @@ -0,0 +1,13 @@ > +# N1SDP specific TFA support > + > +COMPATIBLE_MACHINE = "n1sdp" > +TFA_PLATFORM = "n1sdp" > +TFA_BUILD_TARGET = "bl31" > +TFA_DEBUG = "1" > +TFA_MBEDTLS = "0" > +TFA_UBOOT = "0" > + > +FILESEXTRAPATHS_prepend := "${THISDIR}/files/n1sdp:" > +SRC_URI_append = " \ > + file://0001-n1sdp-arm-tf-disable-workaround-for-N1-Erratum-13157.patch \ > + " > diff --git a/meta-arm-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a_2.2.bbappend b/meta-arm-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a_2.2.bbappend > new file mode 100644 > index 0000000..a87999f > --- /dev/null > +++ b/meta-arm-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a_2.2.bbappend > @@ -0,0 +1,11 @@ > +# Machine specific TFAs > + > +MACHINE_TFA_REQUIRE ?= "" > +MACHINE_TFA_REQUIRE_n1sdp = "trusted-firmware-a-n1sdp.inc" > + > +require ${MACHINE_TFA_REQUIRE} > + > +# TFA referred in release tag N1SDP-2020.03.26 > +SRCREV_tfa_n1sdp = "cfb3f73344217aa000aaff9d84baad7527af75bf" > + > +PV_n1sdp = "2.2+git${SRCPV}" > -- > 2.17.1 > >