Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jiKDZ-0006O0-Sa for mharc-qemu-riscv@gnu.org; Mon, 08 Jun 2020 12:01:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37782) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jiKDX-0006La-8k for qemu-riscv@nongnu.org; Mon, 08 Jun 2020 12:01:43 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:51308 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jiKDV-0007iM-Tm for qemu-riscv@nongnu.org; Mon, 08 Jun 2020 12:01:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591632101; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gxT4B45O1zWyFYki8IWzx+7CIdrw2K/5FRLdU4/GP/s=; b=N2DdErRqsyskEuGnIL6IIOra+szxgFTHezrH3k0nylRDWuV5ophAD6etCKcTawrsz+1NAp GZg3tyFIeLDnBXR5q6xZgD9JXWkA9kASGqE/FAzhtm4i5fxoyVhuZABTJwOglFafAz6Z97 +HVomMRl/DPlD9V7hNYGcjleYUuGI7g= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-292-Gna9PnKPOtef9keKnWpdvg-1; Mon, 08 Jun 2020 12:01:39 -0400 X-MC-Unique: Gna9PnKPOtef9keKnWpdvg-1 Received: by mail-wr1-f71.google.com with SMTP id t5so7325807wro.20 for ; Mon, 08 Jun 2020 09:01:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gxT4B45O1zWyFYki8IWzx+7CIdrw2K/5FRLdU4/GP/s=; b=hzZKYGLv8YcNCFUDfE/xX/J1kxnQB8FQZ2CnNGyaeAJD/N7/EylOe7ahMAAFEpd5Fc aClKD2x+b+J+S/+hPfWiZb7ZwQmhFSJ8EDMQaEgtcc3duqw/w+hUhleJ3w0fHBkojuQC TSwwdf+/wGs8a2qIuhQUNsLLsjei70LzC8kEH6n442ozQ4AjUfjgNWiCeTdFPkRvpRA8 VyNWoi2Ihvqdrc43QS6hmqgAGCqf4NuNUySpisgG0PmeDKgF/xRDQFKJ9jjDZQOn0J88 mWyg2NTcLt5SQzgDwL6IS/h/nqo0B0b8Gtix8fRZGTSUxHlOWnDClJTPrPKAdEOTwAP7 g57w== X-Gm-Message-State: AOAM5333kbTmyXJsu84LZy59bAaDYrrdcQAVPfS6jrIMOyzEIqg8YTeY BntKkGzyuzJD6y1X6QDM6Cy5/2WoN+K8yFlkTLoT6mq9HAPmk/jkjtbauT6rqmBuXxnHvLZ+fXR XHvC21r3LDDYRwjI= X-Received: by 2002:a05:600c:2215:: with SMTP id z21mr76247wml.48.1591632098181; Mon, 08 Jun 2020 09:01:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxecWPcyOuK8uF9ReCv2dq+PoGEfPzfu+FZfYV8n2WgE2MmJ6zu0OPEpglwHYV7Ppo9rtY/wQ== X-Received: by 2002:a05:600c:2215:: with SMTP id z21mr76223wml.48.1591632098001; Mon, 08 Jun 2020 09:01:38 -0700 (PDT) Received: from localhost.localdomain (181.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.181]) by smtp.gmail.com with ESMTPSA id g3sm188327wrb.46.2020.06.08.09.01.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 09:01:37 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Markus Armbruster , Max Filippov , Marcel Apfelbaum , Peter Maydell , Michael Walle , "Edgar E. Iglesias" , Aurelien Jarno , Gerd Hoffmann , Stafford Horne , Andrzej Zaborowski , qemu-ppc@nongnu.org, Alistair Francis , Richard Henderson , Mark Cave-Ayland , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , "Daniel P . Berrange" , qemu-riscv@nongnu.org, "Michael S. Tsirkin" , xen-devel@lists.xenproject.org, Sagar Karandikar , Anthony Perard , Palmer Dabbelt , Stefano Stabellini , Paul Durrant , Paolo Bonzini , Alistair Francis , Eduardo Habkost , Thomas Huth , Bastian Koppelmann , David Gibson , Magnus Damm , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH 09/35] hw/display/ramfb: Emit warning when old code is used Date: Mon, 8 Jun 2020 18:00:18 +0200 Message-Id: <20200608160044.15531-10-philmd@redhat.com> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200608160044.15531-1-philmd@redhat.com> References: <20200608160044.15531-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8; text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=205.139.110.120; envelope-from=philmd@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/08 01:05:50 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Jun 2020 16:01:43 -0000 This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/display/ramfb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/display/ramfb.c b/hw/display/ramfb.c index 79b9754a58..a4a427e5c7 100644 --- a/hw/display/ramfb.c +++ b/hw/display/ramfb.c @@ -18,6 +18,7 @@ #include "hw/display/bochs-vbe.h" /* for limits */ #include "ui/console.h" #include "sysemu/reset.h" +#include "hw/qdev-deprecated.h" struct QEMU_PACKED RAMFBCfg { uint64_t addr; @@ -120,6 +121,8 @@ RAMFBState *ramfb_setup(Error **errp) FWCfgState *fw_cfg = fw_cfg_find(); RAMFBState *s; + qdev_warn_deprecated_function_used(); + if (!fw_cfg || !fw_cfg->dma_enabled) { error_setg(errp, "ramfb device requires fw_cfg with DMA"); return NULL; -- 2.21.3