Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D4A5C433E0 for ; Mon, 8 Jun 2020 14:11:33 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 849322076C for ; Mon, 8 Jun 2020 14:11:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=aepfle.de header.i=@aepfle.de header.b="hxKUaGql" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 849322076C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aepfle.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jiIUj-00013e-2Q; Mon, 08 Jun 2020 14:11:21 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jiIUg-00013N-Hv for xen-devel@lists.xenproject.org; Mon, 08 Jun 2020 14:11:19 +0000 X-Inumbo-ID: eac43954-a991-11ea-b27d-12813bfff9fa Received: from mo4-p00-ob.smtp.rzone.de (unknown [81.169.146.217]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id eac43954-a991-11ea-b27d-12813bfff9fa; Mon, 08 Jun 2020 14:11:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1591625476; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=CVDd4uHHAw9fgz0xLmk75Ws90S2daYPWZzP5U81wMt4=; b=hxKUaGqlVVCgAgnTelfS1ynhQmwLZ12KT4/dNS16gZV0zFQCwoyUx56re2DTneeNpH DQMs4V47U91ZW+ZBVlEHggOHgGIRMJB+jHJrbKJU0ZFiScehRaxKiVZOSNtLyE/t2hgw cDZn2FREHaX02xFCZ1b0QmFqQ9lUMrxDI7fcy+RTjOkpcTYLno5YJ1dYrfBkVVCGoQSY jLEmTLQlmyCpuuElygXePMW6um4zauSil0h2zw+Dm5VyYjYiP5dEt8kFaIxI2CMBgCEp hV1R5gw4BC3+xXWXjBl+Z7AdHC75wiuWEbawCejYLGFFRtkmtiKo6Ho4J1c/TUnnj+3a hlRg== X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QED/SSGq+wjGiUC4AUztn93FPS2dyuYMxg4g==" X-RZG-CLASS-ID: mo00 Received: from sender by smtp.strato.de (RZmta 46.9.2 DYNA|AUTH) with ESMTPSA id I09bd2w58EBDH0E (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Mon, 8 Jun 2020 16:11:13 +0200 (CEST) Date: Mon, 8 Jun 2020 16:11:11 +0200 From: Olaf Hering To: Jason Andryuk Subject: Re: [PATCH v1] tools: fix usage of strncpy Message-ID: <20200608161111.26c2cdd4.olaf@aepfle.de> In-Reply-To: References: <20200608072855.26589-1-olaf@aepfle.de> <20200608100051.16be834e.olaf@aepfle.de> <24286.6790.983312.672969@mariner.uk.xensource.com> X-Mailer: Claws Mail 2020.06.03 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/tHnWh5rOkRJp/RG5rGICI/S"; protocol="application/pgp-signature" X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony PERARD , Ian Jackson , Wei Liu , xen-devel Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" --Sig_/tHnWh5rOkRJp/RG5rGICI/S Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Am Mon, 8 Jun 2020 08:43:50 -0400 schrieb Jason Andryuk : > I added a length check in this patch: gcc will not recognize such runtime checks and will (most likely) complain = about the strncpy usage anyway, just as it does now in libxl__prepare_socka= ddr_un. While the usage in libxl__prepare_sockaddr_un is fatal due to -Werr= or, libvchan is apparently built without -Werror. Olaf --Sig_/tHnWh5rOkRJp/RG5rGICI/S Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAl7eRv8ACgkQ86SN7mm1 DoDYKQ//aDUkyNOaXvmB6HqJfnD3qnWNyYFjXjvWcwyLLlk+KbqF3YrAKC7web4D yuoYnZysjoZUCi7dscvfbu3Gbk3FLe2/B0junH4jspf4CY32oD9dZlw5nGXGdTjX N2hzUCyaIZlVcO/3ryJe1/LywXMclW5aKowziHcMO1NhyhE8NwS1jLST+UjrV9/E 4L485sx2OXi6RWalA4l5luGQVp4mi/cSNdUgQb3/yQ2FgUE/2NNBxPQvE0uP3YKw EbFSy0H6iiGNjRL9dCZgJnkI8AK19WMLEsBAEvNyQdJpdeQyG6rKWT8W7LdCeU4l KzSZdgoJneJFJ4Tq5RzTP3P8Z0v3PCXZXCYcyjDjfK9eo4a7TR4QFEyKnlZ9Zuuh Mx2tM1iLWgVUOvRfd9GE3SNEFSlpvEC22ehwTiGwQfEZACWMXeZYse5N0v/btNiy ab+1NpWU0I8n9coo20iM+XK7G5C1b42UvbtQc9XGuuOFRibKMvzW3k7rd+Ydaprg X8PG7hizAFf1gfkHcOIA2Lp7j8K9qvX0a0o2IDqiDCG9sonaNVf1EFua0HCOjQ/c wZTy47FaUd3KAkmeOD/ojMWEd4Krg4Fz7t5gYuUbPqSjFwxJoZXZ1COzX4rp4eHV we7z7m+rFubDYwuC70owZPwI0bnxn4VtXPxOLhOnpqWTif1cyZw= =FK7T -----END PGP SIGNATURE----- --Sig_/tHnWh5rOkRJp/RG5rGICI/S--