Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEC50C433E0 for ; Mon, 8 Jun 2020 21:06:00 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8DBF92074B for ; Mon, 8 Jun 2020 21:06:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=poorly.run header.i=@poorly.run header.b="BG19wTK0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8DBF92074B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=poorly.run Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 377A96E9A0; Mon, 8 Jun 2020 21:06:00 +0000 (UTC) Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) by gabe.freedesktop.org (Postfix) with ESMTPS id 030826E99F for ; Mon, 8 Jun 2020 21:05:59 +0000 (UTC) Received: by mail-qk1-x743.google.com with SMTP id c185so18769619qke.7 for ; Mon, 08 Jun 2020 14:05:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=poorly.run; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=3lGoCASmqmL0XGiwgCZ6IM26DMk0q5eTR7kt4CPxXww=; b=BG19wTK0x5LAh+DAGVfERtOj2MwsfYjUNa05eEj3LkEcCnV2ed/Oa6lxdi42MOkN02 wdP6DMHAneF9NWov5i5r1CFDOy7hkusEDIaJgnKFxaEHrMUv6EeZHXe2Yyx0uMuSA1Bk /FXUh7bKWDuHkLQOikYie/y2e9JZnP+FoSl9f0A1aXxopgbXMFSFucy1aMECnVzm1THG jhp55w7SJ+z3yBgMZKwcbfBD+kdKYgapYyevaSZ6fJTVr8KpQeyANibXqhHlRPVHyMci myxG8ISvMhiDMO/PyWGsc60TATvNaOLWm1czmQc2kXHcT230sr58ZoGGDkTDrifiwEll j/Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=3lGoCASmqmL0XGiwgCZ6IM26DMk0q5eTR7kt4CPxXww=; b=dLAPDPklUqFJf06ONOeCpoCxlHn+vzOo2v4E87RQcd4qwTLrx4Imi5hvyzuLOcCKb7 OeQvsiT2j8O6Gf/B3k/nzwu5kJKByuxphggASO5C4uXDr7YdJoDaLnupFyTQgHibkMmN xvkEj1gqinbFr/HKWO2aY675sI0EqWVp5xnSZGPe1tdW73OEQ8Fw1T0SG/9ILPiLw74r mwrjCtKkwKVB2d6sLJam6MRgg2MMuhglWJljM1WxwHCMbNZfhqlPkWxfYcyuh/mztBrM l6lrURTeiuRcNIuC3MirMkA6NNQ6sNqgo7LI1city1UyzEAN53o6ZIwx/dVDy4FaJRX8 EBlg== X-Gm-Message-State: AOAM531c8sT4JBFnuc9OnSMpcVJMLwIjlow7IStP/Iom5DwY1M+Qxv0Q 49UUIgMNYNVP0XzOtKUEjDIdmQ== X-Google-Smtp-Source: ABdhPJw8Jjk7oif/BBxPbHlXuh/tL5TFWd+obsWTrGA596OmBAk4bdIfGNk7j9+0DpB8+KziOP5gVA== X-Received: by 2002:a05:620a:133b:: with SMTP id p27mr23224008qkj.444.1591650358159; Mon, 08 Jun 2020 14:05:58 -0700 (PDT) Received: from localhost (mobile-166-173-249-24.mycingular.net. [166.173.249.24]) by smtp.gmail.com with ESMTPSA id a27sm8698275qtc.92.2020.06.08.14.05.57 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 08 Jun 2020 14:05:57 -0700 (PDT) From: Sean Paul To: dri-devel@lists.freedesktop.org Subject: [PATCH v5 06/13] drm/amd: Gate i2c transaction logs on drm_debug_syslog Date: Mon, 8 Jun 2020 17:04:56 -0400 Message-Id: <20200608210505.48519-7-sean@poorly.run> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200608210505.48519-1-sean@poorly.run> References: <20200608210505.48519-1-sean@poorly.run> X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , David Airlie , daniel.vetter@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, ppaalanen@gmail.com, Sean Paul , amd-gfx@lists.freedesktop.org, tzimmermann@suse.de, Alex Deucher , airlied@gmail.com, =?UTF-8?q?Christian=20K=C3=B6nig?= MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" From: Sean Paul Since the logs protected by these checks specifically target syslog, use the new drm_debug_syslog_enabled() call to avoid triggering these prints when only trace is enabled. Signed-off-by: Sean Paul Changes in v5: -Added to the set --- drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c b/drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c index 9bffbab35041..9bc6baddd302 100644 --- a/drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c +++ b/drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c @@ -233,7 +233,7 @@ static uint32_t smu_v11_0_i2c_transmit(struct i2c_adapter *control, DRM_DEBUG_DRIVER("I2C_Transmit(), address = %x, bytes = %d , data: ", (uint16_t)address, numbytes); - if (drm_debug_enabled(DRM_UT_DRIVER)) { + if (drm_debug_syslog_enabled(DRM_UT_DRIVER)) { print_hex_dump(KERN_INFO, "data: ", DUMP_PREFIX_NONE, 16, 1, data, numbytes, false); } @@ -387,7 +387,7 @@ static uint32_t smu_v11_0_i2c_receive(struct i2c_adapter *control, DRM_DEBUG_DRIVER("I2C_Receive(), address = %x, bytes = %d, data :", (uint16_t)address, bytes_received); - if (drm_debug_enabled(DRM_UT_DRIVER)) { + if (drm_debug_syslog_enabled(DRM_UT_DRIVER)) { print_hex_dump(KERN_INFO, "data: ", DUMP_PREFIX_NONE, 16, 1, data, bytes_received, false); } -- Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx