Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B54DEC433E0 for ; Tue, 9 Jun 2020 15:46:12 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 74A0A206A4 for ; Tue, 9 Jun 2020 15:46:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 74A0A206A4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jigRk-0005GT-8C; Tue, 09 Jun 2020 15:45:52 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jigRi-0005GO-Uk for xen-devel@lists.xenproject.org; Tue, 09 Jun 2020 15:45:50 +0000 X-Inumbo-ID: 4add515a-aa68-11ea-b339-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 4add515a-aa68-11ea-b339-12813bfff9fa; Tue, 09 Jun 2020 15:45:50 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 83301AC5B; Tue, 9 Jun 2020 15:45:52 +0000 (UTC) From: Juergen Gross To: xen-devel@lists.xenproject.org Subject: [PATCH for-4.14] xen/hypfs: fix loglvl parameter setting Date: Tue, 9 Jun 2020 17:45:46 +0200 Message-Id: <20200609154546.4531-1-jgross@suse.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Stefano Stabellini , Julien Grall , Wei Liu , paul@xen.org, Andrew Cooper , Ian Jackson , George Dunlap , Jan Beulich Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Writing the runtime parameters loglvl or guest_loglvl omits setting the new length of the resulting parameter value. Reported-by: George Dunlap Signed-off-by: Juergen Gross --- xen/drivers/char/console.c | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c index 56e24821b2..861ad53a8f 100644 --- a/xen/drivers/char/console.c +++ b/xen/drivers/char/console.c @@ -241,14 +241,25 @@ static int _parse_loglvl(const char *s, int *lower, int *upper, char *val) static int parse_loglvl(const char *s) { - return _parse_loglvl(s, &xenlog_lower_thresh, &xenlog_upper_thresh, - xenlog_val); + int ret; + + ret = _parse_loglvl(s, &xenlog_lower_thresh, &xenlog_upper_thresh, + xenlog_val); + custom_runtime_set_var(param_2_parfs(parse_loglvl), xenlog_val); + + return ret; } static int parse_guest_loglvl(const char *s) { - return _parse_loglvl(s, &xenlog_guest_lower_thresh, - &xenlog_guest_upper_thresh, xenlog_guest_val); + int ret; + + ret = _parse_loglvl(s, &xenlog_guest_lower_thresh, + &xenlog_guest_upper_thresh, xenlog_guest_val); + custom_runtime_set_var(param_2_parfs(parse_guest_loglvl), + xenlog_guest_val); + + return ret; } static char *loglvl_str(int lvl) -- 2.26.2