Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8460C433E0 for ; Wed, 10 Jun 2020 06:46:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7D2892074B for ; Wed, 10 Jun 2020 06:46:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=yadro.com header.i=@yadro.com header.b="V5JyLOyF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726180AbgFJGqM (ORCPT ); Wed, 10 Jun 2020 02:46:12 -0400 Received: from mta-02.yadro.com ([89.207.88.252]:33238 "EHLO mta-01.yadro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726095AbgFJGqL (ORCPT ); Wed, 10 Jun 2020 02:46:11 -0400 Received: from localhost (unknown [127.0.0.1]) by mta-01.yadro.com (Postfix) with ESMTP id 6E3464C855; Wed, 10 Jun 2020 06:46:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yadro.com; h= in-reply-to:content-disposition:content-type:content-type :mime-version:references:message-id:subject:subject:from:from :date:date:received:received:received; s=mta-01; t=1591771567; x=1593585968; bh=t/cVmz/qNDcxhWkMzBFcmAL2ODoGFNl//m+OK/Vsmvo=; b= V5JyLOyFmMST+zVhKI3whzJqEfxf4vT3PFzfveLuO8+EhiMBzgBKcYAepHNseJsI 9j4E9+QzCTwjSkEmIvVK0scC4iHo0DLMLKqCg8cqT9/uY+UEAinlN3bLJZ3ESX/l zudkrgsUjxIIouGJot2DMol8iWo3Pc+D7ZxFp0ythVc= X-Virus-Scanned: amavisd-new at yadro.com Received: from mta-01.yadro.com ([127.0.0.1]) by localhost (mta-01.yadro.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5N_HwbAfC1aQ; Wed, 10 Jun 2020 09:46:07 +0300 (MSK) Received: from T-EXCH-02.corp.yadro.com (t-exch-02.corp.yadro.com [172.17.10.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mta-01.yadro.com (Postfix) with ESMTPS id 2AB1D49961; Wed, 10 Jun 2020 09:46:07 +0300 (MSK) Received: from localhost (172.17.204.212) by T-EXCH-02.corp.yadro.com (172.17.10.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.669.32; Wed, 10 Jun 2020 09:46:07 +0300 Date: Wed, 10 Jun 2020 09:46:06 +0300 From: Roman Bolshakov To: Bart Van Assche CC: "Martin K . Petersen" , "James E . J . Bottomley" , , Nilesh Javali , Quinn Tran , Himanshu Madhani , Hannes Reinecke , Daniel Wagner Subject: Re: [PATCH v2] qla2xxx: Fix the ARM build Message-ID: <20200610064606.GA30572@SPB-NB-133.local> References: <20200610024215.27997-1-bvanassche@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20200610024215.27997-1-bvanassche@acm.org> X-Originating-IP: [172.17.204.212] X-ClientProxiedBy: T-EXCH-01.corp.yadro.com (172.17.10.101) To T-EXCH-02.corp.yadro.com (172.17.10.102) Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On Tue, Jun 09, 2020 at 07:42:15PM -0700, Bart Van Assche wrote: > This patch fixes the build errors reported by the kernel test robot on June > 7th. Does this perhaps mean that so far nobody has tried to use the qla2xxx > driver on an ARM system? For the kernel test robot output, see also > https://lore.kernel.org/lkml/202006070558.Cy93XggE%25lkp@intel.com/. > > Cc: Nilesh Javali > Cc: Quinn Tran > Cc: Himanshu Madhani > Cc: Hannes Reinecke > Cc: Daniel Wagner > Cc: Roman Bolshakov > Signed-off-by: Bart Van Assche > --- > drivers/scsi/qla2xxx/qla_def.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h > index 42dbf90d4651..de9c1604c575 100644 > --- a/drivers/scsi/qla2xxx/qla_def.h > +++ b/drivers/scsi/qla2xxx/qla_def.h > @@ -46,7 +46,7 @@ typedef struct { > uint8_t al_pa; > uint8_t area; > uint8_t domain; > -} le_id_t; > +} __packed le_id_t; > > #include "qla_bsg.h" > #include "qla_dsd.h" Reviewed-by: Roman Bolshakov BTW, it might worth to mention the bot found the issue: Reported-by: kernel test robot Thanks, Roman