From: Michal Hocko Subject: Re: mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page Date: Fri, 12 Jun 2020 14:09:04 +0200 Message-ID: <20200612120904.GA8641@dhcp22.suse.cz> References: <20200528150310.GG27484@dhcp22.suse.cz> <20200528164121.GA839178@chrisdown.name> <20200529015644.GA84588@chrisdown.name> <20200529094910.GH4406@dhcp22.suse.cz> <20200611095514.GD20450@dhcp22.suse.cz> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Naresh Kamboju Cc: Chris Down , Yafang Shao , Anders Roxell , "Linux F2FS DEV, Mailing List" , linux-ext4 , linux-block , Andrew Morton , open list , Linux-Next Mailing List , linux-mm , Arnd Bergmann , Andreas Dilger , Jaegeuk Kim , Theodore Ts'o , Chao Yu , Hugh Dickins , Andrea Arcangeli , Matthew Wilcox , Chao Yu , On Fri 12-06-20 15:13:22, Naresh Kamboju wrote: > On Thu, 11 Jun 2020 at 15:25, Michal Hocko wrote: > > > > On Fri 29-05-20 11:49:20, Michal Hocko wrote: > > > On Fri 29-05-20 02:56:44, Chris Down wrote: > > > > Yafang Shao writes: > > > Agreed. Even if e{low,min} might still have some rough edges I am > > > completely puzzled how we could end up oom if none of the protection > > > path triggers which the additional debugging should confirm. Maybe my > > > debugging patch is incomplete or used incorrectly (maybe it would be > > > esier to use printk rather than trace_printk?). > > > > It would be really great if we could move forward. While the fix (which > > has been dropped from mmotm) is not super urgent I would really like to > > understand how it could hit the observed behavior. Can we double check > > that the debugging patch really doesn't trigger (e.g. > > s@trace_printk@printk in the first step)? > > Please suggest to me the way to get more debug information > by providing kernel debug patches and extra kernel configs. > > I have applied your debug patch and tested on top on linux next 20200612 > but did not find any printk output while running mkfs -t ext4 /drive test case. Have you tried s@trace_printk@printk@ in the patch? AFAIK trace_printk doesn't dump anything into the printk ring buffer. You would have to look into trace ring buffer. -- Michal Hocko SUSE Labs