From: Tom Rini Date: Mon, 15 Jun 2020 09:38:25 -0400 Subject: [PATCH 2/2] omap4: sdp: convert to device model In-Reply-To: References: <20200615101605.19922-1-peter.ujfalusi@ti.com> <20200615101605.19922-3-peter.ujfalusi@ti.com> <20200615125357.GS24893@bill-the-cat> <85f8dd2b-8b8d-670b-8660-0d2cb043295f@ti.com> <20200615131455.GT24893@bill-the-cat> Message-ID: <20200615133825.GY24893@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Jun 15, 2020 at 04:35:52PM +0300, Peter Ujfalusi wrote: > Hi Tom, > > On 15/06/2020 16.14, Tom Rini wrote: > > On Mon, Jun 15, 2020 at 04:08:51PM +0300, Tero Kristo wrote: > >> On 15/06/2020 15:53, Tom Rini wrote: > >>> On Mon, Jun 15, 2020 at 01:16:05PM +0300, Peter Ujfalusi wrote: > >>> > >>>> Convert omap4 sdp to device model. > >>>> > >>>> Signed-off-by: Peter Ujfalusi > >>>> --- > >>>> arch/arm/dts/Makefile | 4 ++++ > >>>> board/ti/sdp4430/sdp.c | 12 ++++++++++++ > >>>> configs/omap4_sdp4430_defconfig | 8 ++++++++ > >>>> 3 files changed, 24 insertions(+) > >>> > >>> Please note that this, like the pandaboard series, aren't dealing with > >>> the DM_SPI conversion which brought up removing this to start with. > >>> While I'm pretty sure pandaboard exposes SPI on a header, I don't know > >>> if sdp does and perhaps you just want to remove SPI? Thanks! > >> > >> Can you provide a reference to the DM_SPI discussion? > >> > >> I guess we could remove DM_SPI from pandaboard also if it is causing > >> problems. My initial attempt on that series was just to get basic boot > >> working via MMC, and that should be done now if I am not terribly > >> mistaken... > > > > It's over in > > http://patchwork.ozlabs.org/project/uboot/patch/20200527125637.149189-16-jagan at amarulasolutions.com/ > > but there's not much to discuss as the DM_SPI / DM_SPI_FLASH conversion > > deadline was a year ago this next release, hence the removal of > > platforms that haven't. The good news for OMAP4 (and OMAP5) is that the > > driver itself has already been converted so it's no more work than the > > USB, etc, conversions that you've both done recently. Thanks! > > Adding DM_SPI to the defconfig? In the board file I don't see any trace > of SPI being enabled or used. > As I said, the ethernet would need SPI, but that never worked in mainline.. It's enabled in the defconfig today. If you don't want to enable SPI in U-Boot (which is fine for the 4430, I assume no one wants to spend the time trying to enable ethernet on it at this point) just disable it. I only have an open question on if that's right for pandaboard because I thought it's exposed on the expansion header, but I don't know how big a deal that is these days really. Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: