Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5484C433E0 for ; Mon, 15 Jun 2020 15:55:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD7F1206B7 for ; Mon, 15 Jun 2020 15:55:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729962AbgFOPzR (ORCPT ); Mon, 15 Jun 2020 11:55:17 -0400 Received: from mga09.intel.com ([134.134.136.24]:3486 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727785AbgFOPzR (ORCPT ); Mon, 15 Jun 2020 11:55:17 -0400 IronPort-SDR: 1ZW89ZvsqdIUrU029kUjyEtH+3uD3vNy/7zQ2HAGQXF4PvKAF4XQrnf0imrDC5szXPi3JtHZuq I4lvfZhxPX4w== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jun 2020 08:55:16 -0700 IronPort-SDR: seU07Fxs5k/IX3atuuSktgojZOVWQgHbFR/GdGcRBkFl5WnrbFlQTuxAqM2IWFI0KR+oqClULQ 4m5mgFHq18uw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,515,1583222400"; d="scan'208";a="382582849" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.163]) by fmsmga001.fm.intel.com with SMTP; 15 Jun 2020 08:55:13 -0700 Received: by lahna (sSMTP sendmail emulation); Mon, 15 Jun 2020 18:55:12 +0300 Date: Mon, 15 Jun 2020 18:55:12 +0300 From: Mika Westerberg To: Yehezkel Bernat Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, Michael Jamet , "David S . Miller" , Jakub Kicinski , Andreas Noever , Lukas Wunner , netdev@vger.kernel.org Subject: Re: [PATCH 4/4] thunderbolt: Get rid of E2E workaround Message-ID: <20200615155512.GS247495@lahna.fi.intel.com> References: <20200615130139.83854-1-mika.westerberg@linux.intel.com> <20200615130139.83854-5-mika.westerberg@linux.intel.com> <20200615135112.GA1402792@kroah.com> <20200615142247.GN247495@lahna.fi.intel.com> <20200615153249.GR247495@lahna.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jun 15, 2020 at 06:41:32PM +0300, Yehezkel Bernat wrote: > > I think you are talking about the "prtstns" property in the network > > driver. There we only set TBNET_MATCH_FRAGS_ID (bit 1). This is the > > thing that get exposed to the other side of the connection and we never > > announced support for full E2E. > > > Ah, yes, this one, Thanks! > As Windows driver uses it for flagging full-E2E, and we completely drop E2E > support here, it may worth to mention there that this is what bit 2 is used in > Windows so any reuse should consider the possible compatibility issue. Note we only drop dead code in this patch. It is that workaround for Falcon Ridge controller we actually never used. I can add a comment to the network driver about the full E2E support flag as a separate patch if you think it is useful. The network protocol will be public soon I guess because USB4 spec refers to "USB4 Inter-Domain Specification, Revision 1.0, [to be published] – (USB4 Inter-Domain Specification)" so I would expect it to be explained there as well.