Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74CF6C433E0 for ; Mon, 15 Jun 2020 22:22:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 34E9A20714 for ; Mon, 15 Jun 2020 22:22:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TH7HztRb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 34E9A20714 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37040 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkxVI-0001sb-Ev for qemu-devel@archiver.kernel.org; Mon, 15 Jun 2020 18:22:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50970) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jkxUR-0001Rx-UE for qemu-devel@nongnu.org; Mon, 15 Jun 2020 18:22:04 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:20554 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jkxUP-0007lY-0E for qemu-devel@nongnu.org; Mon, 15 Jun 2020 18:22:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592259718; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4HFqGT+7zPl4lMO9MT5+kJlksbGfjAfEoiqkOEnm5aY=; b=TH7HztRbnBTR838mJhomU4mMResyEENtpx6yanknOA/+CSWcFkg71dO4BhMY/6LZZciRO8 rgV7L+eXdwePxW8sVIUIn09W0415lKPoKZDDlViDfzheUzUCDu4jxWsKGopoiFvIIrrw9T FLgGPD9hWEGdN/094tEGy14PEI/kCR4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-70-y1WDkzy1OKSUo9CfHYVYcw-1; Mon, 15 Jun 2020 18:21:54 -0400 X-MC-Unique: y1WDkzy1OKSUo9CfHYVYcw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 75DC8800EBB for ; Mon, 15 Jun 2020 22:21:53 +0000 (UTC) Received: from localhost (ovpn-114-100.phx2.redhat.com [10.3.114.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 26A755C1C3; Mon, 15 Jun 2020 22:21:53 +0000 (UTC) Date: Mon, 15 Jun 2020 18:21:52 -0400 From: Eduardo Habkost To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [PATCH v3 0/3] python/machine.py: refactor shutdown Message-ID: <20200615222152.GT2366737@habkost.net> References: <20200604195252.20739-1-jsnow@redhat.com> <8bd27ec8-1bb6-45e2-a43a-7e0229065414@redhat.com> <4012de28-5837-889a-eda1-b9957cbbbad1@redhat.com> <5d20012b-923c-0bf4-232d-272977087fe3@redhat.com> MIME-Version: 1.0 In-Reply-To: <5d20012b-923c-0bf4-232d-272977087fe3@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Content-Disposition: inline Received-SPF: pass client-ip=205.139.110.120; envelope-from=ehabkost@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/15 16:38:57 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, WEIRD_PORT=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, Markus Armbruster , John Snow , qemu-devel@nongnu.org, Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Jun 15, 2020 at 05:21:18PM +0200, Philippe Mathieu-Daudé wrote: > On 6/9/20 11:55 PM, John Snow wrote: > > > > > > On 6/9/20 9:08 AM, Philippe Mathieu-Daudé wrote: > >> Hi John, > >> > >> On 6/4/20 9:52 PM, John Snow wrote: > >>> v3: > >>> - Split _post_shutdown refactor into own patch (now 1/3) > >>> - Re-add sigkill warning squelch (now 3/3) > >>> > >>> NOTE: I re-added the squelch in its own patch for review purposes, but > >>> for the purposes of avoiding temporary breakage, a maintainer may wish > >>> to squash patches 2 and 3 if they are accepted. > >>> > >>> v2: Philippe took patches 1, 3 and 4. > >>> > >>> This is a re-write of what was: > >>> [PATCH RFC 03/32] python//machine.py: remove bare except > >>> [PATCH 2/4] python/machine.py: remove bare except > >>> > >>> It's a bit heavier handed, but it should address some of kwolf's > >>> feedback from the RFC version. > >>> > >>> Applies straight to origin/master, ought to pass pylint and flake8: > >>> > >>>> cd ~/src/qemu/python/qemu > >>>> pylint *.py > >>>> flake8 *.py > >>> > >>> John Snow (3): > >>> python/machine.py: consolidate _post_shutdown() > >>> python/machine.py: refactor shutdown > >>> python/machine.py: re-add sigkill warning suppression > >>> > >>> python/qemu/machine.py | 100 +++++++++++++++++++++++++++++------------ > >>> 1 file changed, 71 insertions(+), 29 deletions(-) > >>> > >> > >> I'm now seeing this error: > >> > >> 21:31:58 DEBUG| / # reboot > >> 21:32:01 DEBUG| / # reboot: Restarting system > >> 21:32:01 DEBUG| >>> {'execute': 'quit'} > >> 21:32:01 WARNI| qemu received signal 9; command: > >> "mips-softmmu/qemu-system-mips -display none -vga none -chardev > >> socket,id=mon,path=/tmp/tmp679upvrk/qemu-10292-monitor.sock -mon > >> chardev=mon,mode=control -machine malta -chardev > >> socket,id=console,path=/tmp/tmp679upvrk/qemu-10292-console.sock,server,nowait > >> -serial chardev:console -kernel > >> /tmp/avocado_b3aaagr9/avocado_job_5bj0xe1h/12-tests_acceptance_boot_linux_console.py_BootLinuxConsole.test_mips_malta_cpio/boot/vmlinux-4.5.0-2-4kc-malta > >> -initrd > >> /tmp/avocado_b3aaagr9/avocado_job_5bj0xe1h/12-tests_acceptance_boot_linux_console.py_BootLinuxConsole.test_mips_malta_cpiorootfs.cpio > >> -append printk.time=0 console=ttyS0 console=tty rdinit=/sbin/init > >> noreboot -no-reboot" > >> 21:32:01 ERROR| > >> 21:32:01 ERROR| Reproduced traceback from: > >> /home/travis/build/philmd/qemu/build/tests/venv/lib/python3.6/site-packages/avocado/core/test.py:886 > >> 21:32:01 ERROR| Traceback (most recent call last): > >> 21:32:01 ERROR| File > >> "/home/travis/build/philmd/qemu/build/tests/acceptance/avocado_qemu/__init__.py", > >> line 195, in tearDown > >> 21:32:01 ERROR| vm.shutdown() > >> 21:32:01 ERROR| File > >> "/home/travis/build/philmd/qemu/python/qemu/machine.py", line 449, in > >> shutdown > >> 21:32:01 ERROR| self._do_shutdown(has_quit) > >> 21:32:01 ERROR| File > >> "/home/travis/build/philmd/qemu/python/qemu/machine.py", line 426, in > >> _do_shutdown > >> 21:32:01 ERROR| self._soft_shutdown(has_quit, timeout) > >> 21:32:01 ERROR| File > >> "/home/travis/build/philmd/qemu/python/qemu/machine.py", line 413, in > >> _soft_shutdown > >> 21:32:01 ERROR| self._qmp.cmd('quit') > >> 21:32:01 ERROR| File > >> "/home/travis/build/philmd/qemu/python/qemu/qmp.py", line 271, in cmd > >> 21:32:01 ERROR| return self.cmd_obj(qmp_cmd) > >> 21:32:01 ERROR| File > >> "/home/travis/build/philmd/qemu/python/qemu/qmp.py", line 249, in cmd_obj > >> 21:32:01 ERROR| self.__sock.sendall(json.dumps(qmp_cmd).encode('utf-8')) > >> 21:32:01 ERROR| BrokenPipeError: [Errno 32] Broken pipe > >> 21:32:01 ERROR| > >> 21:32:01 DEBUG| DATA (filename=output.expected) => NOT FOUND (data > >> sources: variant, test, file) > >> 21:32:01 DEBUG| DATA (filename=stdout.expected) => NOT FOUND (data > >> sources: variant, test, file) > >> 21:32:01 DEBUG| DATA (filename=stderr.expected) => NOT FOUND (data > >> sources: variant, test, file) > >> 21:32:01 DEBUG| Not logging /var/log/syslog (lack of permissions) > >> 21:32:01 ERROR| ERROR > >> 12-tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_mips_malta_cpio > >> -> TestSetupFail: [Errno 32] Broken pipe > >> 21:32:01 INFO | > >> > >> https://travis-ci.org/github/philmd/qemu/jobs/696142277#L5329 > >> > > > > Gotcha. > > > > The problem here is that `test_mips_malta_cpio` in boot_linux_console.py > > does this: > > > > self.vm.add_args('-kernel', kernel_path, > > '-initrd', initrd_path, > > '-append', kernel_command_line, > > '-no-reboot') > > > > and then: > > > > exec_command_and_wait_for_pattern(self, 'reboot', > > 'reboot: Restarting system') > > > > and (in avocado_qemu/) __init__.py does this: > > > > def tearDown(self): > > for vm in self._vms.values(): > > vm.shutdown() > > > > > > > > What's happening here is that we are instructing QEMU to *close* when > > the guest reboots instead of allowing it to reboot. Then, we are issuing > > a reboot command to the guest, which will effectively terminate QEMU as > > well. Finally, we are trying to send a shutdown command to QEMU, but > > QEMU has already gone. > > > > Now, in the shutdown code, we do make an attempt to catch this: > > > > def is_running(self): > > """Returns true if the VM is running.""" > > return self._popen is not None and self._popen.poll() is None > > > > But, well, race conditions. > > > > When we make it here: > > > > if self._qmp is not None: > > if not has_quit: > > self._qmp.cmd('quit') > > self._qmp.close() > > > > We believe we are running and we believe we have an open QMP socket. > > Attempting to engage the socket by sending 'quit' causes the error. > > > > It's a tight window: if quit happens earlier, we send the command > > successfully and everything's OK. If quit happens later, we realize QEMU > > isn't running and proceed to cleanup. > > Nice debugging :) > > > > > Ultimately: > > > > - Avocado should not try to shut down QEMU twice, but > > - machine.py shouldn't enable the race condition either. > > > > > > > > for my part, how about this: > > > > diff --git a/python/qemu/machine.py b/python/qemu/machine.py > > index 99bcb499878..813f8e477db 100644 > > --- a/python/qemu/machine.py > > +++ b/python/qemu/machine.py > > @@ -385,7 +385,14 @@ def _soft_shutdown(self, has_quit: bool = False, > > timeout: int = 3) -> None: > > > > if self._qmp is not None: > > if not has_quit: > > - self._qmp.cmd('quit') > > + try: > > + self._qmp.cmd('quit') > > + except (BrokenPipeError, ConnectionResetError): > > + # QMP went away just before or just after sending > > 'quit' > > + if not self.is_running(): > > + # "Mission Accomplished" > > + pass > > + raise > > Looks OK to me, Cleber/Eduardo can you Ack? Looks good to me. Reviewed-by: Eduardo Habkost > > > self._qmp.close() > > > > self._popen.wait(timeout=timeout) > > > -- Eduardo