From: Tom Rini Date: Tue, 16 Jun 2020 16:58:12 -0400 Subject: U-Boot atheros PHY support and cubox ethernet In-Reply-To: References: <20200616195505.GA3129@bill-the-cat> <20200616205108.GB24893@bill-the-cat> Message-ID: <20200616205812.GC24893@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Jun 16, 2020 at 05:55:10PM -0300, Fabio Estevam wrote: > On Tue, Jun 16, 2020 at 5:51 PM Tom Rini wrote: > > > Ah. So this is probably why the DT being right isn't helping then. If > > you want to blind-convert I'm happy to test, otherwise do you have a > > similar board conversion for me to look at? Thanks! > > Please try Vladimir's suggestion as it seems to be the less intrusive approach: > > --- a/board/solidrun/mx6cuboxi/mx6cuboxi.c > +++ b/board/solidrun/mx6cuboxi/mx6cuboxi.c > @@ -321,7 +321,7 @@ int board_eth_init(bd_t *bis) > if (!bus) > return -EINVAL; > > - phydev = phy_find_by_mask(bus, ETH_PHY_MASK, PHY_INTERFACE_MODE_RGMII); > + phydev = phy_find_by_mask(bus, ETH_PHY_MASK, > PHY_INTERFACE_MODE_RGMII_ID); > if (!phydev) { > ret = -EINVAL; > goto free_bus; > OK, tried that and not enough. Console says PHY autoneg completes, but DHCP still doesn't reply. > Here is a similar DM_ETH board conversion: > > commit 02ee7a4aa57b37d6003263b69b1852c4cda5975e > Author: Alifer Moraes > Date: Mon Feb 10 11:28:01 2020 -0300 > > mx6sabresd: Convert ethernet to driver model > > Convert imx6sabresd ethernet to driver model to fix the following warning: > > ===================== WARNING ====================== > This board does not use CONFIG_DM_ETH (Driver Model > for Ethernet drivers). Please update the board to use > CONFIG_DM_ETH before the v2020.07 release. Failure to > update by the deadline may result in board removal. > See doc/driver-model/migration.rst for more info. > ==================================================== > > Signed-off-by: Alifer Moraes > Reviewed-by: Fabio Estevam > > Let us know if this helps. I'm looking at the conversion now, thanks. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: