From: Tom Rini Date: Tue, 16 Jun 2020 17:50:19 -0400 Subject: U-Boot atheros PHY support and cubox ethernet In-Reply-To: References: <20200616195505.GA3129@bill-the-cat> <20200616205108.GB24893@bill-the-cat> <20200616205812.GC24893@bill-the-cat> Message-ID: <20200616215019.GF24893@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Jun 17, 2020 at 12:01:39AM +0300, Vladimir Oltean wrote: > On Tue, 16 Jun 2020 at 23:58, Tom Rini wrote: > > > > On Tue, Jun 16, 2020 at 05:55:10PM -0300, Fabio Estevam wrote: > > > On Tue, Jun 16, 2020 at 5:51 PM Tom Rini wrote: > > > > > > > Ah. So this is probably why the DT being right isn't helping then. If > > > > you want to blind-convert I'm happy to test, otherwise do you have a > > > > similar board conversion for me to look at? Thanks! > > > > > > Please try Vladimir's suggestion as it seems to be the less intrusive approach: > > > > > > --- a/board/solidrun/mx6cuboxi/mx6cuboxi.c > > > +++ b/board/solidrun/mx6cuboxi/mx6cuboxi.c > > > @@ -321,7 +321,7 @@ int board_eth_init(bd_t *bis) > > > if (!bus) > > > return -EINVAL; > > > > > > - phydev = phy_find_by_mask(bus, ETH_PHY_MASK, PHY_INTERFACE_MODE_RGMII); > > > + phydev = phy_find_by_mask(bus, ETH_PHY_MASK, > > > PHY_INTERFACE_MODE_RGMII_ID); > > > if (!phydev) { > > > ret = -EINVAL; > > > goto free_bus; > > > > > > > OK, tried that and not enough. Console says PHY autoneg completes, but > > DHCP still doesn't reply. > > > > What about with the manual revert in place? What does > phydev->interface print? Not only in atheros.c, but also in > mx6cuboxi.c, right below this phy_find_by_mask call. > Trying to understand if this is your only problem or if there are more. In both functions the value printed out for phydev->interface is the value passed to phy_find_by_mask(...). -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: