From: Tom Rini Date: Wed, 17 Jun 2020 17:30:36 -0400 Subject: U-Boot atheros PHY support and cubox ethernet In-Reply-To: References: <20200616195505.GA3129@bill-the-cat> <20200616205108.GB24893@bill-the-cat> <20200616205812.GC24893@bill-the-cat> <20200616223005.GB27801@bill-the-cat> <20200617190020.GF27801@bill-the-cat> Message-ID: <20200617213036.GJ27801@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Jun 17, 2020 at 06:28:37PM -0300, Fabio Estevam wrote: > Hi Tom, > > On Wed, Jun 17, 2020 at 4:00 PM Tom Rini wrote: > > > Based on your follow-up patches, I think you'll be unsurprised it > > doesn't work. I get: > > Net: Could not get PHY for FEC0: addr 0 > > Now I understand why the PHY could not be found with the patches I sent. > > On mx6cubox the AR8035 is clocked from a 25MHz clock coming from the > i.MX6 GPIO16 pin. > > My patch incorrectly removed this setting. > > > + int ret = enable_fec_anatop_clock(0, ENET_25MHZ); > > + if (ret) > > + return ret; > > + > > + /* set gpr1[ENET_CLK_SEL] */ > > + setbits_le32(&iomuxc_regs->gpr[1], IOMUXC_GPR1_ENET_CLK_SEL_MASK); > > enable_fec_anatop_clock() and GPR1 settings above must remain. > > In order to get patch 1 to work (the one that adds the > qca,clk-out-frequency property ) you also need this FEC change: > https://pastebin.com/raw/mcKdwwTs > > I hope this helps. I'll test that out tomorrow. But my question now is, what do you want to do about the various platforms where ethernet isn't working? -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: