Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED145C433E1 for ; Thu, 18 Jun 2020 01:21:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C26A020663 for ; Thu, 18 Jun 2020 01:21:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592443279; bh=q6q9H6WERydXHsFxXw1t9PgwznLXrB3iVaZ9haQcOfM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=k0U+kjBTdGVQOT4KegzeJvDWUzHb7p68nZemSN2OEAkh6/I9HFT1Fi3sHgB6hw+QV r/i4YTy1tTToYCUoR/P+gR4mNT/BNJaijrshcDiqhUKNA2t/5r9GPwPmE3WrYiDRUU xJhoSGTst7+o8HZ0J2N1p4H+dVbja5UnXyOmVGX0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727995AbgFRBVS (ORCPT ); Wed, 17 Jun 2020 21:21:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:53684 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730475AbgFRBVR (ORCPT ); Wed, 17 Jun 2020 21:21:17 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B82C320663; Thu, 18 Jun 2020 01:21:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592443276; bh=q6q9H6WERydXHsFxXw1t9PgwznLXrB3iVaZ9haQcOfM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EZ0xpsx/Mv4pcImlFnqg9BfLYgHWQUT6ett+poa7ock36vRBOOLi007kYzoiCnnSr LcnFUyTTdzmUXkebAxkqWrNOqWMMZmQ7jl9RgOtPYBRtu0g57sLRLsweHix70nY65J U5xuEsyZ3Hrd7v+nbEV7+Qr5G4O74Y47CjhoOt7k= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Can Guo , Stanley Chu , "Martin K . Petersen" , Sasha Levin , linux-scsi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH AUTOSEL 5.4 221/266] scsi: ufs: Don't update urgent bkops level when toggling auto bkops Date: Wed, 17 Jun 2020 21:15:46 -0400 Message-Id: <20200618011631.604574-221-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200618011631.604574-1-sashal@kernel.org> References: <20200618011631.604574-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org From: Can Guo [ Upstream commit be32acff43800c87dc5c707f5d47cc607b76b653 ] Urgent bkops level is used to compare against actual bkops status read from UFS device. Urgent bkops level is set during initialization and might be updated in exception event handler during runtime. But it should not be updated to the actual bkops status every time when auto bkops is toggled. Otherwise, if urgent bkops level is updated to 0, auto bkops shall always be kept enabled. Link: https://lore.kernel.org/r/1590632686-17866-1-git-send-email-cang@codeaurora.org Fixes: 24366c2afbb0 ("scsi: ufs: Recheck bkops level if bkops is disabled") Reviewed-by: Stanley Chu Signed-off-by: Can Guo Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/ufs/ufshcd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index bc73181b0405..2b6853c7375c 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -5101,7 +5101,6 @@ static int ufshcd_bkops_ctrl(struct ufs_hba *hba, err = ufshcd_enable_auto_bkops(hba); else err = ufshcd_disable_auto_bkops(hba); - hba->urgent_bkops_lvl = curr_status; out: return err; } -- 2.25.1