Return-Path: Date: Thu, 18 Jun 2020 12:17:59 +0300 From: Mike Rapoport Subject: Re: [PATCH] mm: Move p?d_alloc_track to separate header file Message-ID: <20200618091759.GH6493@linux.ibm.com> References: <20200609120533.25867-1-joro@8bytes.org> <20200617181226.ab213ea1531b5dd6eca1b0b6@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200617181226.ab213ea1531b5dd6eca1b0b6@linux-foundation.org> Sender: owner-linux-mm@kvack.org To: Andrew Morton Cc: Joerg Roedel , peterz@infradead.org, jroedel@suse.de, Andy Lutomirski , Abdul Haleem , Satheesh Rajendran , Stephen Rothwell , manvanth@linux.vnet.ibm.com, linux-next@vger.kernel.org, Steven Rostedt , Linus Torvalds , linuxppc-dev@lists.ozlabs.org, hch@lst.de, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: Message-ID: <20200618091759.9L7htKHz8jydKmB3waQq7bDlZkkMhehciRf7IJn_eb0@z> On Wed, Jun 17, 2020 at 06:12:26PM -0700, Andrew Morton wrote: > On Tue, 9 Jun 2020 14:05:33 +0200 Joerg Roedel wrote: > > > From: Joerg Roedel > > > > The functions are only used in two source files, so there is no need > > for them to be in the global header. Move them to the new > > header and include it only where needed. > > > > ... > > > > new file mode 100644 > > index 000000000000..1dcc865029a2 > > --- /dev/null > > +++ b/include/linux/pgalloc-track.h > > @@ -0,0 +1,51 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +#ifndef _LINUX_PGALLLC_TRACK_H > > +#define _LINUX_PGALLLC_TRACK_H > > hm, no #includes. I guess this is OK, given the limited use. > > But it does make one wonder whether ioremap.c should be moved from lib/ > to mm/ and this file should be moved from include/linux/ to mm/. It makes sense, but I am anyway planning consolidation of pgalloc.h, so most probably pgalloc-track will not survive until 5.9-rc1 :) If you think that it worth moving ioremap.c to mm/ regardless of chrun, I can send a patch for that. > Oh well. -- Sincerely yours, Mike.