From: Tom Rini Date: Thu, 18 Jun 2020 09:38:50 -0400 Subject: [PATCH] phy: atheros: ar8035: Fix clock output calculation In-Reply-To: <20200618030859.29060-1-festevam@gmail.com> References: <20200618030859.29060-1-festevam@gmail.com> Message-ID: <20200618133850.GL27801@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Jun 18, 2020 at 12:08:59AM -0300, Fabio Estevam wrote: > The "qca,clk-out-frequency" is calculated incorrectly for AR8035 > due to incorrect masking of priv->clk_25m_reg and priv->clk_25m_mask. > > This same issue has been already fixed in the kernel by: > > commit b1f4c209d84057b6d40b939b6e4404854271d797 > Author: Oleksij Rempel > Date: Wed Apr 1 11:57:32 2020 +0200 > > net: phy: at803x: fix clock sink configuration on ATH8030 and ATH8035 > > The masks in priv->clk_25m_reg and priv->clk_25m_mask are one-bits-set > for the values that comprise the fields, not zero-bits-set. > > This patch fixes the clock frequency configuration for ATH8030 and > ATH8035 Atheros PHYs by removing the erroneous "~". > > To reproduce this bug, configure the PHY with the device tree binding > "qca,clk-out-frequency" and remove the machine specific PHY fixups. > > Fixes: 2f664823a47021 ("net: phy: at803x: add device tree binding") > Signed-off-by: Oleksij Rempel > Reported-by: Russell King > Reviewed-by: Russell King > Tested-by: Russell King > Signed-off-by: David S. Miller > > Apply the same fix in the U-Boot driver. > > Tested on a i.MX6 Hummingboard. > > Reported-by: Tom Rini > Signed-off-by: Fabio Estevam What else do I need with this to test it myself? This alone doesn't do it (but I'm not surprised) and adding the 2 DM_ETH patches you sent to convert the platform still gives the "Could not get PHY for FEC0: addr 0" error message. Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: