Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0B9BC433DF for ; Thu, 18 Jun 2020 15:50:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D6A98206FA for ; Thu, 18 Jun 2020 15:50:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728169AbgFRPuD (ORCPT ); Thu, 18 Jun 2020 11:50:03 -0400 Received: from mx2.suse.de ([195.135.220.15]:33378 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727911AbgFRPuC (ORCPT ); Thu, 18 Jun 2020 11:50:02 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 50604AF4C; Thu, 18 Jun 2020 15:50:01 +0000 (UTC) Date: Thu, 18 Jun 2020 17:50:01 +0200 From: Daniel Wagner To: Christoph Hellwig Cc: Jens Axboe , Peter Zijlstra , linux-block@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH 04/12] blk-mq: complete polled requests directly Message-ID: <20200618155001.anayfvmkhrejxtc4@beryllium.lan> References: <20200611064452.12353-1-hch@lst.de> <20200611064452.12353-5-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200611064452.12353-5-hch@lst.de> Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, Jun 11, 2020 at 08:44:44AM +0200, Christoph Hellwig wrote: > Even for single queue devices there is no point in offloading a polled > completion to the softirq, given that blk_mq_force_complete_rq is called > from the polling thread in that case and thus there are no starvation > issues. > > Signed-off-by: Christoph Hellwig Reviewed-by: Daniel Wagner