From: sbabic at denx.de Date: Tue, 23 Jun 2020 09:51:31 +0200 (CEST) Subject: [PATCH v3 1/4] phy: atheros: ar8035: Fix clock output calculation In-Reply-To: <20200618232120.3289-1-festevam@gmail.com> Message-ID: <20200623075131.C6AA081F06@phobos.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de > The clock ouput frequency is calculated incorrectly for AR8035 due to > wrong masking of priv->clk_25m_reg and priv->clk_25m_mask. > This same issue has been already fixed in the kernel by: > commit b1f4c209d84057b6d40b939b6e4404854271d797 > Author: Oleksij Rempel > Date: Wed Apr 1 11:57:32 2020 +0200 > net: phy: at803x: fix clock sink configuration on ATH8030 and ATH8035 > The masks in priv->clk_25m_reg and priv->clk_25m_mask are one-bits-set > for the values that comprise the fields, not zero-bits-set. > This patch fixes the clock frequency configuration for ATH8030 and > ATH8035 Atheros PHYs by removing the erroneous "~". > To reproduce this bug, configure the PHY with the device tree binding > "qca,clk-out-frequency" and remove the machine specific PHY fixups. > Fixes: 2f664823a47021 ("net: phy: at803x: add device tree binding") > Signed-off-by: Oleksij Rempel > Reported-by: Russell King > Reviewed-by: Russell King > Tested-by: Russell King > Signed-off-by: David S. Miller > Apply the same fix in the U-Boot driver. > Tested on a i.MX6 Hummingboard. > Signed-off-by: Fabio Estevam > Reviewed-by: Michael Walle > Tested-by: Tom Rini Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================