Content-Type: multipart/mixed; boundary="===============8877635416204296087==" MIME-Version: 1.0 From: Paul E. McKenney To: kbuild-all@lists.01.org Subject: Re: [PATCH tip/core/rcu 3/3] srcu: Remove KCSAN stubs Date: Tue, 23 Jun 2020 20:57:41 -0700 Message-ID: <20200624035741.GA9247@paulmck-ThinkPad-P72> In-Reply-To: <202006240942.Me9X4XnX%lkp@intel.com> List-Id: --===============8877635416204296087== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Wed, Jun 24, 2020 at 09:43:38AM +0800, kernel test robot wrote: > Hi, > = > I love your patch! Yet something to improve: > = > [auto build test ERROR on tip/core/rcu] > = > url: https://github.com/0day-ci/linux/commits/paulmck-kernel-org/srcu-= Fix-a-typo-in-comment-amoritized-amortized/20200623-085757 > base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git cb3cb= 6733fbd8fd8d2c716095fdca42dadba2063 > config: x86_64-rhel-7.6 (attached as .config) > compiler: gcc-9 (Debian 9.3.0-13) 9.3.0 > reproduce (this is a W=3D1 build): > # save the attached .config to linux build tree > make W=3D1 ARCH=3Dx86_64 = > = > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > = > All errors (new ones prefixed by >>): > = > kernel/rcu/srcutree.c: In function 'srcu_torture_stats_print': > >> kernel/rcu/srcutree.c:1271:8: error: implicit declaration of function = 'data_race' [-Werror=3Dimplicit-function-declaration] > 1271 | u0 =3D data_race(sdp->srcu_unlock_count[!idx]); > | ^~~~~~~~~ > cc1: some warnings being treated as errors This definition is in mainline, just not in v5.7. So if you apply this patch to v5.8-rc1, it should work fine. I have nevertheless moved this patch to my v5.10 stack to avoid confusion. Thanx, Paul > vim +/data_race +1271 kernel/rcu/srcutree.c > = > 1f4f6da1c80905 Paul E. McKenney 2017-04-21 1254 = > aacb5d91ab1bfb Paul E. McKenney 2018-10-28 1255 void srcu_torture_stats= _print(struct srcu_struct *ssp, char *tt, char *tf) > 115a1a5285664f Paul E. McKenney 2017-05-22 1256 { > 115a1a5285664f Paul E. McKenney 2017-05-22 1257 int cpu; > 115a1a5285664f Paul E. McKenney 2017-05-22 1258 int idx; > ac3748c6042660 Paul E. McKenney 2017-05-22 1259 unsigned long s0 =3D 0= , s1 =3D 0; > 115a1a5285664f Paul E. McKenney 2017-05-22 1260 = > aacb5d91ab1bfb Paul E. McKenney 2018-10-28 1261 idx =3D ssp->srcu_idx = & 0x1; > 52e17ba1d063ab Paul E. McKenney 2018-06-19 1262 pr_alert("%s%s Tree SR= CU g%ld per-CPU(idx=3D%d):", > aacb5d91ab1bfb Paul E. McKenney 2018-10-28 1263 tt, tf, rcu_seq_curr= ent(&ssp->srcu_gp_seq), idx); > 115a1a5285664f Paul E. McKenney 2017-05-22 1264 for_each_possible_cpu(= cpu) { > 115a1a5285664f Paul E. McKenney 2017-05-22 1265 unsigned long l0, l1; > 115a1a5285664f Paul E. McKenney 2017-05-22 1266 unsigned long u0, u1; > 115a1a5285664f Paul E. McKenney 2017-05-22 1267 long c0, c1; > 5ab07a8df4d6c9 Paul E. McKenney 2018-05-22 1268 struct srcu_data *sdp; > 115a1a5285664f Paul E. McKenney 2017-05-22 1269 = > aacb5d91ab1bfb Paul E. McKenney 2018-10-28 1270 sdp =3D per_cpu_ptr(s= sp->sda, cpu); > b68c6146512d92 Paul E. McKenney 2020-01-03 @1271 u0 =3D data_race(sdp-= >srcu_unlock_count[!idx]); > b68c6146512d92 Paul E. McKenney 2020-01-03 1272 u1 =3D data_race(sdp-= >srcu_unlock_count[idx]); > 115a1a5285664f Paul E. McKenney 2017-05-22 1273 = > 115a1a5285664f Paul E. McKenney 2017-05-22 1274 /* > 115a1a5285664f Paul E. McKenney 2017-05-22 1275 * Make sure that a l= ock is always counted if the corresponding > 115a1a5285664f Paul E. McKenney 2017-05-22 1276 * unlock is counted. > 115a1a5285664f Paul E. McKenney 2017-05-22 1277 */ > 115a1a5285664f Paul E. McKenney 2017-05-22 1278 smp_rmb(); > 115a1a5285664f Paul E. McKenney 2017-05-22 1279 = > b68c6146512d92 Paul E. McKenney 2020-01-03 1280 l0 =3D data_race(sdp-= >srcu_lock_count[!idx]); > b68c6146512d92 Paul E. McKenney 2020-01-03 1281 l1 =3D data_race(sdp-= >srcu_lock_count[idx]); > 115a1a5285664f Paul E. McKenney 2017-05-22 1282 = > 115a1a5285664f Paul E. McKenney 2017-05-22 1283 c0 =3D l0 - u0; > 115a1a5285664f Paul E. McKenney 2017-05-22 1284 c1 =3D l1 - u1; > 7e210a653ec944 Paul E. McKenney 2019-06-28 1285 pr_cont(" %d(%ld,%ld = %c)", > 7e210a653ec944 Paul E. McKenney 2019-06-28 1286 cpu, c0, c1, > 7e210a653ec944 Paul E. McKenney 2019-06-28 1287 "C."[rcu_segcblist_e= mpty(&sdp->srcu_cblist)]); > ac3748c6042660 Paul E. McKenney 2017-05-22 1288 s0 +=3D c0; > ac3748c6042660 Paul E. McKenney 2017-05-22 1289 s1 +=3D c1; > 115a1a5285664f Paul E. McKenney 2017-05-22 1290 } > ac3748c6042660 Paul E. McKenney 2017-05-22 1291 pr_cont(" T(%ld,%ld)\n= ", s0, s1); > 115a1a5285664f Paul E. McKenney 2017-05-22 1292 } > 115a1a5285664f Paul E. McKenney 2017-05-22 1293 EXPORT_SYMBOL_GPL(srcu_= torture_stats_print); > 115a1a5285664f Paul E. McKenney 2017-05-22 1294 = > = > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============8877635416204296087==--