From: Dan Carpenter Date: Thu, 25 Jun 2020 09:04:49 +0000 Subject: Re: [PATCH] intel_idle: Fix uninitialized variable bug Message-Id: <20200625090449.GA2549@kadam> List-Id: References: <20200624131921.GB9972@mwanda> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Rafael J. Wysocki" Cc: Jacob Pan , "Rafael J. Wysocki" , Len Brown , Linux PM , Linux Kernel Mailing List , kernel-janitors@vger.kernel.org, Kees Cook On Wed, Jun 24, 2020 at 03:41:05PM +0200, Rafael J. Wysocki wrote: > On Wed, Jun 24, 2020 at 3:19 PM Dan Carpenter wrote: > > > > The "tick" variable isn't initialized if "lapic_timer_always_reliable" > > is true. > > If lapic_timer_always_reliable is true, then > static_cpu_has(X86_FEATURE_ARAT) must also be true AFAICS. > > So the lapic_timer_always_reliable check in there looks redundant. Can the lapic_timer_always_reliable variable just be removed entirely and replaced with an static_cpu_has(X86_FEATURE_ARAT) check? regards, dan carpenter