Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20472C433DF for ; Thu, 25 Jun 2020 09:06:32 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED20A20720 for ; Thu, 25 Jun 2020 09:06:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED20A20720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1joNph-0006Fg-GJ; Thu, 25 Jun 2020 09:06:09 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1joNpg-0006Fb-Gu for xen-devel@lists.xenproject.org; Thu, 25 Jun 2020 09:06:08 +0000 X-Inumbo-ID: 16aaeb38-b6c3-11ea-bb8b-bc764e2007e4 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 16aaeb38-b6c3-11ea-bb8b-bc764e2007e4; Thu, 25 Jun 2020 09:06:01 +0000 (UTC) Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: NpTbVswjo87d4caBxN9k+22+xmt/dGD2e+OOGemKXq5UnATBigsn9aqNzbgmARQ7/NZ1wzWgmM 681gYm76hdW8A1FxFmu6PUFIDlzY58IkHs5qkPuloyqIgoxXABYoWFyemp3cGlyLkZUTAURSkm aXBIneIttUtTvdlExngsVZpD7++5F0plLZcI9UtgGn+xzGr89iaK/bom22sOjnwu8Crd4LUcuO DW4KYScaA4G8Z2gH1YRHyybqaEudg3PM848kJX6IYS81NE396MYljv7yrnNKAhlIjXl8+h3ku3 WJg= X-SBRS: 2.7 X-MesageID: 20910537 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,278,1589256000"; d="scan'208";a="20910537" Date: Thu, 25 Jun 2020 11:05:52 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Subject: Re: [PATCH for-4.14] mm: fix public declaration of struct xen_mem_acquire_resource Message-ID: <20200625090552.GW735@Air-de-Roger> References: <20200623135246.66170-1-roger.pau@citrix.com> <50e25ef7-e7a7-d2c1-5f78-ce32cae35f38@suse.com> <20200623155609.GS735@Air-de-Roger> <20200623172652.GU735@Air-de-Roger> <24d35c4d-e2b3-1f58-4c6e-71072de01b74@suse.com> <04410978-33bf-dedf-7401-248b1a038a9c@xen.org> <60ac0a67-1448-4b39-4489-42dc008b6355@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <60ac0a67-1448-4b39-4489-42dc008b6355@suse.com> X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , paul@xen.org, Andrew Cooper , Ian Jackson , George Dunlap , xen-devel@lists.xenproject.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Wed, Jun 24, 2020 at 04:01:44PM +0200, Jan Beulich wrote: > On 24.06.2020 15:41, Julien Grall wrote: > > On 24/06/2020 11:12, Jan Beulich wrote: > >> On 23.06.2020 19:26, Roger Pau Monné wrote: > >>> I'm confused. Couldn't we switch from uint64_aligned_t to plain > >>> uint64_t (like it's currently on the Linux headers), and then use the > >>> compat layer in Xen to handle the size difference when called from > >>> 32bit environments? > >> > >> And which size would we use there? The old or the new one (breaking > >> future or existing callers respectively)? Meanwhile I think that if > >> this indeed needs to not be tools-only (which I still question), > > > > I think we now agreed on a subthread that the kernel needs to know the > > layout of the hypercall. > > > >> then our only possible route is to add explicit padding for the > >> 32-bit case alongside the change you're already making. > > > > AFAICT Linux 32-bit doesn't have this padding. So wouldn't it make > > incompatible the two incompatible? > > In principle yes. But they're putting the structure instance on the > stack, so there's not risk from Xen reading 4 bytes too many. I'd > prefer keeping the interface as is (i.e. with the previously > implicit padding made explicit) to avoid risking to break other > possible callers. But that's just my view on it, anyway ... Adding the padding is cleaner because we don't need any compat stuff in order to access the structure from the caller, and we also keep the original layout currently present on Xen headers. I can prepare a fix for the Linux kernel, if this approach is fine. Roger.