From: Boris Brezillon Date: Fri, 26 Jun 2020 10:35:08 +0000 Subject: Re: [PATCH] drm/vc4: call ->post_disable() functions in vc4_dsi_encoder_disable() Message-Id: <20200626123508.0a726db3@collabora.com> List-Id: References: <20200626103401.GA314359@mwanda> In-Reply-To: <20200626103401.GA314359@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Andrzej Hajda , David Airlie , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org On Fri, 26 Jun 2020 13:34:01 +0300 Dan Carpenter wrote: > The problem is that the iterator is already at the list head so the > list_for_each_entry_from() loop is a no-op and we don't call the > the iter->funcs->post_disable() functions. This should be > list_for_each_entry() instead. > > Fixes: 033bfe7538a1 ("drm/vc4: dsi: Fix bridge chain handling") > Signed-off-by: Dan Carpenter Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/vc4/vc4_dsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c > index eaf276978ee7..f92d0e92fa72 100644 > --- a/drivers/gpu/drm/vc4/vc4_dsi.c > +++ b/drivers/gpu/drm/vc4/vc4_dsi.c > @@ -754,7 +754,7 @@ static void vc4_dsi_encoder_disable(struct drm_encoder *encoder) > > vc4_dsi_ulps(dsi, true); > > - list_for_each_entry_from(iter, &dsi->bridge_chain, chain_node) { > + list_for_each_entry(iter, &dsi->bridge_chain, chain_node) { > if (iter->funcs->post_disable) > iter->funcs->post_disable(iter); > }