From: Jason Gunthorpe Subject: Re: [PATCH] nouveau: fix page fault on device private memory Date: Fri, 26 Jun 2020 14:44:37 -0300 Message-ID: <20200626174437.GD23821@mellanox.com> References: <20200626172626.19207-1-rcampbell@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20200626172626.19207-1-rcampbell-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Nouveau" To: Ralph Campbell Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ben Skeggs , Christoph Hellwig List-Id: nouveau.vger.kernel.org On Fri, Jun 26, 2020 at 10:26:26AM -0700, Ralph Campbell wrote: > If system memory is migrated to device private memory and no GPU MMU > page table entry exists, the GPU will fault and call hmm_range_fault() > to get the PFN for the page. Since the .dev_private_owner pointer in > struct hmm_range is not set, hmm_range_fault returns an error which > results in the GPU program stopping with a fatal fault. > Fix this by setting .dev_private_owner appropriately. > > Fixes: 08ddddda667b ("mm/hmm: check the device private page owner in hmm_range_fault()") > Signed-off-by: Ralph Campbell > --- > > This is based on Linux-5.8.0-rc2 and is for Ben Skeggs nouveau tree. > It doesn't depend on any of the other nouveau/HMM changes I have > recently posted. Makes sense to me Reviewed-by: Jason Gunthorpe Jason