From: Dan Carpenter Date: Sat, 27 Jun 2020 17:54:45 +0000 Subject: Re: [PATCH] scsi: ufs: ufs-exynos: Remove an unnecessary NULL check Message-Id: <20200627175445.GG2571@kadam> List-Id: References: <20200626105133.GF314359@mwanda> <041701d64ca7$70bafb80$5230f280$@samsung.com> In-Reply-To: <041701d64ca7$70bafb80$5230f280$@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alim Akhtar Cc: 'Avri Altman' , "'James E.J. Bottomley'" , "'Martin K. Petersen'" , 'Kukjin Kim' , 'Krzysztof Kozlowski' , 'Kiwoong Kim' , 'Wei Yongjun' , linux-scsi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On Sat, Jun 27, 2020 at 10:51:44PM +0530, Alim Akhtar wrote: > Hi Dan > > > -----Original Message----- > > The "head" pointer can't be NULL because it points to an address in the > middle > > of a ufs_hba struct. Looking at this code, probably someone would wonder > if > > the intent was to check whether "hba" is NULL, but "hba" > > isn't NULL and the check can just be removed. > > > > Signed-off-by: Dan Carpenter > > --- > Please add Fixes: tag > With that > Acked-by: Alim Akhtar It's not a bug fix it's just a cleanup. regards, dan carpenter