Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2467EC433DF for ; Mon, 29 Jun 2020 06:44:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF3A523137 for ; Mon, 29 Jun 2020 06:44:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="u6W1dgEJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF3A523137 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=P1f3pzKTyDrHlArSJ2k2Neutwykpmh6iJ71GkNYst2k=; b=u6W1dgEJTDR4ls5jzP1mTUXSI SmK6rC8ZcRfigSz+OAiGM/pHyvb5Bh8i0qqDJGFfLl9CGdofUpztT3BAbwFtX5LYn3fenPt4wSENf mYwk6m792wqEgu9XyR5Dt/E3KMhsKhfIiPkrYu9NU/+zdWvalK6wl8zdE0Gwf4vtMW6q8AIVW75iU ZiSl1fY2AvmtkPWU+Cp77JChH7OFMG0inX6VAW+jn+yB84hHlZ35ER185+OoqsWE2njZpx3Dv12Si 0c/ona3XEyUIV0Dk4LunXH4EnKxHhPFf8s0ESBfvdW5zKDpO9UyXwGev5274fjh1R8hOfMHT3y5yX m/jeLDbdQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpnWW-0004K7-1m; Mon, 29 Jun 2020 06:44:12 +0000 Received: from verein.lst.de ([213.95.11.211]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpnWJ-0004Jp-2x for linux-nvme@lists.infradead.org; Mon, 29 Jun 2020 06:44:00 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id B832468AFE; Mon, 29 Jun 2020 08:43:49 +0200 (CEST) Date: Mon, 29 Jun 2020 08:43:49 +0200 From: Christoph Hellwig To: Sagi Grimberg Subject: Re: [PATCH v3] nvme: fix identify error status silent ignore Message-ID: <20200629064349.GB30821@lst.de> References: <20200626174629.115730-1-sagi@grimberg.me> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200626174629.115730-1-sagi@grimberg.me> User-Agent: Mutt/1.5.17 (2007-11-01) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Keith Busch , Christoph Hellwig , linux-nvme@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Fri, Jun 26, 2020 at 10:46:29AM -0700, Sagi Grimberg wrote: > Patch 59c7c3caaaf8 intended to only silently ignore > non retry-able errors (DNR bit set) such that we can still > identify misbehaving controllers, and in the other hand > propagate retry-able errors (DNR bit cleared) so we don't > wrongly abandon a namespace just because it happens to be > temporarily inaccessible. > > The goal remains the same as the original commit where this > was introduced but unfortunately had the logic backwards. So how did this work all the time? I'm really worried that someone this is actually going to break things. What do you think about only queueing it up for 5.9 for now? _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme