Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 508CEC433E0 for ; Mon, 29 Jun 2020 11:39:17 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C875923B1F for ; Mon, 29 Jun 2020 11:39:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="Pc6hxvEk"; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="v5Jg0pnh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C875923B1F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 55AED847; Mon, 29 Jun 2020 13:38:25 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 55AED847 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1593430755; bh=QzfAborYCJUbuQbilhwh6UvjIbH/wMLPAczW1yjFyh4=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Pc6hxvEka1i6lVb+iFnENFJOHAa7faIZLh9dgPsWlcU8rCOpXTTHXgp5VlvHVevV+ /pNUN5Ha0ZyKwgWFzEZ34Qa7yY4PS5JjR2WRXUz4PWe2L/wwnA5ThchqUFkwaiyCLw RmifzocWsQA/vuJxxR041+WevUXoc+ZmVxBWdKvY= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id E5C14F80096; Mon, 29 Jun 2020 13:38:24 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 23BADF80217; Mon, 29 Jun 2020 13:38:24 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 83038F80096 for ; Mon, 29 Jun 2020 13:38:20 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 83038F80096 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="v5Jg0pnh" Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EC06B23AA9; Mon, 29 Jun 2020 11:38:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593430699; bh=QzfAborYCJUbuQbilhwh6UvjIbH/wMLPAczW1yjFyh4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=v5Jg0pnhArgYZz7LwLBjPlxtd6vRTYj0IOIMgp4rLOtYhBhAuafiiFr1vhpfOXwEN wrLxjpA8RS4p9ETJ3bn26UcUa5xsSPDqXpo985VwwYsS29nEj5h/tDrEszjRw2fBLs A/Ouu84R0teTabEMp0IKBsB6oAkMRUIAPBfYxfeY= Date: Mon, 29 Jun 2020 12:38:17 +0100 From: Mark Brown To: Tzung-Bi Shih Subject: Re: [PATCH v2 0/3] ASoC: rt1015: fix compilation errors and warnings Message-ID: <20200629113817.GA5499@sirena.org.uk> References: <20200625153543.85039-1-tzungbi@google.com> <159311231750.10637.12370136760007816881.b4-ty@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="huq684BweRXVnRxX" Content-Disposition: inline In-Reply-To: X-Cookie: Real programs don't eat cache. User-Agent: Mutt/1.10.1 (2018-07-13) Cc: ALSA development X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --huq684BweRXVnRxX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jun 29, 2020 at 01:48:41PM +0800, Tzung-Bi Shih wrote: > On Fri, Jun 26, 2020 at 3:12 AM Mark Brown wrote: > > > The original patch: > > > (1) adds acpi.h for fixing implicit declaration of function 'ACPI_PTR' > > > (2) sorts header inclusions in alphabetical > I am wondering if it is a better practice (next time) to separate the > original patch into 2 patches. Yes. --huq684BweRXVnRxX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl750qgACgkQJNaLcl1U h9Dg/Qf+OaAkpz/aIixrhzre+qPOfsUVRsz3H/h/6pErGWfbWeyTbiDzWHs+J01f fKrZ8l5W2McTNghRKu/zI4btcfgR9KYQIDtd4HwSyuE956B5qP41nAFZaNpNbyBQ Xw/L2aw4wjRDaeRMeVZm32pvYyC3j2nvQRaZpqt91i9kA/7SBjuws5TfY8dbPPEw LeidLoz7dNPHIbddRbK2KB43owoMHdVvPP8gYHNQZm9ZPaU1Lzph6erywCXRmYFp o6fxMw0047gXsVoVRrkjjVZNoyPAovf3VgrZanWu/cIxXyGk3DpQytJIrifGU6Ta nTLkAc8YQH0LGqb6QyZb8s+tZVtE+w== =WwzM -----END PGP SIGNATURE----- --huq684BweRXVnRxX--