Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jq9JQ-0006It-D1 for mharc-qemu-trivial@gnu.org; Tue, 30 Jun 2020 02:00:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57160) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jq9JO-0006H1-JX for qemu-trivial@nongnu.org; Tue, 30 Jun 2020 02:00:06 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:52641 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jq9JM-0000I3-92 for qemu-trivial@nongnu.org; Tue, 30 Jun 2020 02:00:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593496802; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type; bh=w+H+FMV8Z5eikLECDxnhdARKkB1uGFMaBwUXXA8jiPs=; b=M8htkF03gmRM5EXEEG3ekfqcgqr1xEkuJLkI+IO8Gn7G0xSg6ojDmm9zc+2i7qJWllmEYD UkGED3UK6rAEKgBcc9jsvJE1LHpV0SLD50AL31wH+kyke20MTSTsFZAWCU9bhRadrKB5L5 3Rm99lEl6VFvxjk6SoiKHNqyjrZUEhA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-135-r_cGvIFhPriAu4IrOLbg5Q-1; Tue, 30 Jun 2020 02:00:00 -0400 X-MC-Unique: r_cGvIFhPriAu4IrOLbg5Q-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8BA981005512; Tue, 30 Jun 2020 05:59:59 +0000 (UTC) Received: from thuth.com (ovpn-112-46.ams2.redhat.com [10.36.112.46]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4FEC85D9CC; Tue, 30 Jun 2020 05:59:55 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org, Yoshinori Sato Cc: qemu-trivial@nongnu.org Subject: [PATCH] disas/sh4: Add missing fallthrough annotations Date: Tue, 30 Jun 2020 07:59:53 +0200 Message-Id: <20200630055953.9309-1-thuth@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Received-SPF: pass client-ip=207.211.31.120; envelope-from=thuth@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/30 00:34:33 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Jun 2020 06:00:07 -0000 Add fallthrough annotations to be able to compile the code without warnings with -Wimplicit-fallthrough. Looking at the code, it seems like the fallthrough is indeed intended here, so the comments should be appropriate. Signed-off-by: Thomas Huth --- Note: The new lines use TABs since all the surounding code uses TABs, too. Please ignore the checkpatch warnings. disas/sh4.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/disas/sh4.c b/disas/sh4.c index 55ef865a36..dcdbdf26d8 100644 --- a/disas/sh4.c +++ b/disas/sh4.c @@ -1963,6 +1963,7 @@ print_insn_sh (bfd_vma memaddr, struct disassemble_info *info) fprintf_fn (stream, "xd%d", rn & ~1); break; } + /* fallthrough */ case D_REG_N: fprintf_fn (stream, "dr%d", rn); break; @@ -1972,6 +1973,7 @@ print_insn_sh (bfd_vma memaddr, struct disassemble_info *info) fprintf_fn (stream, "xd%d", rm & ~1); break; } + /* fallthrough */ case D_REG_M: fprintf_fn (stream, "dr%d", rm); break; -- 2.18.1