Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D8A4C433DF for ; Sat, 4 Jul 2020 01:16:22 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id EC7BE2075D for ; Sat, 4 Jul 2020 01:16:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=qq.com header.i=@qq.com header.b="nKE6hxDB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC7BE2075D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=qq.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E1C0B1DCAC; Sat, 4 Jul 2020 03:16:15 +0200 (CEST) Received: from qq.com (out203-205-251-88.mail.qq.com [203.205.251.88]) by dpdk.org (Postfix) with ESMTP id 29A031DC94; Sat, 4 Jul 2020 03:16:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1593825358; bh=fFMTvmiRdwxKu8AkoHcAdrsy3s1J6B75lQA2PRE7nwQ=; h=From:To:Cc:Subject:Date; b=nKE6hxDBDj5drGR/hOyT9i+WVNltq/CaFemSpTOZ9AyIK/64mUCAj4x8EKnvW5+w8 ErtJaRkap5aDsvgroY5vope27nMMO4+0K9m8q+Q0Ol66X1CIyFi8bSIoFotu2v13lA 2UQYunn1eVTNKchhGKz6cBQlmkNxwq5kEJKjOC2s= Received: from localhost.localdomain ([122.234.234.97]) by newxmesmtplogicsvrszc5.qq.com (NewEsmtp) with SMTP id 3F7804D3; Sat, 04 Jul 2020 09:15:55 +0800 X-QQ-mid: xmsmtpt1593825355t7q24hn7p Messag-ID: X-QQ-XMAILINFO: NSoebXH2o9jL7z+NCUdTe8KHHQfNqbdnIdhPwM5w+Vd3BniEgoteJV2r+HcPZN 38CsWqAIJpkOgOSgkKY2nGadYi9TRljg7uV/zoR8f2DgtvCedPy722aBC2gZNmIA1cIJiz4WzfK9 UH4VzDsSOPANvil67bvwERSNqJHotGtu3FJxIQABkE0/dLIsedAQEquQZlr2KzGoLRCG2qmUozTc JAF72ey5HdQyBmx2Kq3WIamg1lxSbNqXZKjhNWot0fdUg2u+AjlkAV7ZE5i58d8mXaKXfigB24F+ 24vp9tEHX2BCbFqR9RxMwMaDb5clucYjZryPReBeKeBeaz7ZwIxBkFNgLkIOKUrzKvKXS7xWOHaU 3yb0w8/jGzizz32d3fWcQCLgza6ST0rBvZi3c5LEZYGd7tA/+QDu6G34EQSMZgRdKbPWTcfg5WF2 gZzfLCS3M9WbpdlgsE9bks1w2E3w4sTiF8Tw545ok8GwFMPTTih+4WGh3+BrBx11DH599iTzBInm gHpN9u/EmljmCQdtr9qSQRXp7/NM+PVutpfxwBw9Evx5YTSYGTKmG9VmW7NtnSdU4dMliwrNe0m1 YzuPahX7FlNLzxtYyQtfU8vo/Og8VbMHg3G2oXUt7TkwA+3g6A4hZKYugpqOvbIc6aUeHQpibJrj x43Rsd3rKXfUzDIMOasErj8ZV5R3/NttXbjw== From: 197020236@qq.com To: xavier.huwei@huawei.com Cc: dev@dpdk.org, pandongyang <197020236@qq.com>, stable@dpdk.org Date: Sat, 4 Jul 2020 09:15:26 +0800 X-OQ-MSGID: <20200704011526.662-1-197020236@qq.com> X-Mailer: git-send-email 2.23.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH V2] net/bonding: delete redundant code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-Id: <20200704011615.E1C0B1DCAC@dpdk.org> From: pandongyang <197020236@qq.com> The function valid_bonded_port_id() has already contains function rte_eth_dev_is_valid_port(), so delete redundant check. Fixes: 588ae95e7983 ("net/bonding: fix port ID check") Cc: stable@dpdk.org Signed-off-by: pandongyang <197020236@qq.com> --- v1 -> v2: Adjust commit info --- drivers/net/bonding/rte_eth_bond_8023ad.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c index b77a37ddb..339374337 100644 --- a/drivers/net/bonding/rte_eth_bond_8023ad.c +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c @@ -1675,9 +1675,6 @@ rte_eth_bond_8023ad_dedicated_queues_enable(uint16_t port) dev = &rte_eth_devices[port]; internals = dev->data->dev_private; - if (check_for_bonded_ethdev(dev) != 0) - return -1; - if (bond_8023ad_slow_pkt_hw_filter_supported(port) != 0) return -1; @@ -1704,9 +1701,6 @@ rte_eth_bond_8023ad_dedicated_queues_disable(uint16_t port) dev = &rte_eth_devices[port]; internals = dev->data->dev_private; - if (check_for_bonded_ethdev(dev) != 0) - return -1; - /* Device must be stopped to set up slow queue */ if (dev->data->dev_started) return -1; -- 2.23.0.windows.1